Page MenuHomePhabricator
Create Task
Maniphest T243209

Refactor banners for wikipedia.de
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

  • WP.de
    • Use BannerPresenter
    • Use shared components instead of local components, while keeping/adapting the CSS. Extract SelectGroup.pcss and adapt the sectioned class names (removed fullwidth, halfwidth and quarterwidth classes).
    • Fix eventual bugs/inconsistencies
    • Clean up shared directory

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedNoneT242202 Refactor Banners
 ResolvedNoneT243209 Refactor banners for wikipedia.de

Event Timeline

kai.nissen created this task.Jan 20 2020, 1:59 PM
kai.nissen set the point value for this task to 3.Jan 20 2020, 2:04 PM
kai.nissen added a project: WMDE-FUN-Sprint-2020-01-20.Jan 20 2020, 2:12 PM
kai.nissen removed a project: WMDE-FUN-Sprint-2020-01-20.Jan 20 2020, 2:28 PM
kai.nissen moved this task from Backlog to Current Sprint on the WMDE-Fundraising-Tech board.Jan 20 2020, 3:28 PM
kai.nissen moved this task from Current Sprint to Sprint ready on the WMDE-Fundraising-Tech board.
gabriel-wmde updated the task description. (Show Details)Jan 22 2020, 9:39 AM
kai.nissen added a project: WMDE-FUN-Sprint-2020-03-02.Mar 2 2020, 12:34 PM
CorinnaHillebrand_WMDE claimed this task.Mar 4 2020, 4:49 PM
CorinnaHillebrand_WMDE moved this task from Todo to Doing on the WMDE-FUN-Sprint-2020-03-02 board.
kai.nissen moved this task from Sprint ready to Current Sprint on the WMDE-Fundraising-Tech board.Mar 13 2020, 11:03 AM
kai.nissen added a project: WMDE-FUN-Sprint-2020-03-16.Mar 16 2020, 10:54 AM
kai.nissen changed the point value for this task from 3 to 5.
kai.nissen moved this task from Todo to Doing on the WMDE-FUN-Sprint-2020-03-16 board.Mar 16 2020, 11:02 AM
kai.nissen changed the point value for this task from 5 to 2.Mar 30 2020, 9:56 AM
kai.nissen added a project: WMDE-FUN-Sprint-2020-03-30.Mar 30 2020, 9:59 AM
kai.nissen moved this task from Todo to Doing on the WMDE-FUN-Sprint-2020-03-30 board.
CorinnaHillebrand_WMDE added a comment.Apr 1 2020, 1:01 PM

@kai.nissen is it correct that the wpde banner should not slide into the page with a transition but just "plop" in after 7,5 seconds like the old banner does currently?

kai.nissen added a comment.Apr 2 2020, 8:00 AM

@CorinnaHillebrand_WMDE The banner just plops in, even without any delay (see example).

CorinnaHillebrand_WMDE removed CorinnaHillebrand_WMDE as the assignee of this task.Apr 3 2020, 9:10 AM
CorinnaHillebrand_WMDE moved this task from Doing to Review on the WMDE-FUN-Sprint-2020-03-30 board.
gabriel-wmde moved this task from Review to Done on the WMDE-FUN-Sprint-2020-03-30 board.Apr 6 2020, 9:11 PM
kai.nissen closed this task as Resolved.Apr 30 2020, 12:34 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL