Page MenuHomePhabricator
Create Task
Maniphest T243218

Argument 1 passed to Wikibase\\Repo\\Store\\PropertyTermsRebuilder::saveTerms() must be an instance of Wikibase\\DataModel\\Entity\\Property, null given
Closed, ResolvedPublic
Actions

Description

https://integration.wikimedia.org/ci/job/beta-update-databases-eqiad/39602/console

Broke beta DB update job

[a9561f0bf42dde367741f55d] [no req]   TypeError from line 105 of /srv/mediawiki-staging/php-master/extensions/Wikibase/repo/includes/Store/PropertyTermsRebuilder.php: Argument 1 passed to Wikibase\\Repo\\Store\\PropertyTermsRebuilder::saveTerms() must be an instance of Wikibase\\DataModel\\Entity\\Property, null given, called in /srv/mediawiki-staging/php-master/extensions/Wikibase/repo/includes/Store/PropertyTermsRebuilder.php on line 100
Backtrace:
#0 /srv/mediawiki-staging/php-master/extensions/Wikibase/repo/includes/Store/PropertyTermsRebuilder.php(100): Wikibase\\Repo\\Store\\PropertyTermsRebuilder->saveTerms(NULL)
#1 /srv/mediawiki-staging/php-master/extensions/Wikibase/repo/includes/Store/PropertyTermsRebuilder.php(75): Wikibase\\Repo\\Store\\PropertyTermsRebuilder->rebuildTermsForBatch(array)
#2 /srv/mediawiki-staging/php-master/extensions/Wikibase/repo/includes/Store/Sql/DatabaseSchemaUpdater.php(280): Wikibase\\Repo\\Store\\PropertyTermsRebuilder->rebuild()
#3 /srv/mediawiki-staging/php-master/includes/installer/DatabaseUpdater.php(490): Wikibase\\Repo\\Store\\Sql\\DatabaseSchemaUpdater::rebuildPropertyTerms(MysqlUpdater)
#4 /srv/mediawiki-staging/php-master/includes/installer/DatabaseUpdater.php(458): DatabaseUpdater->runUpdates(array, boolean)
#5 /srv/mediawiki-staging/php-master/maintenance/update.php(197): DatabaseUpdater->doUpdates(array)
#6 /srv/mediawiki-staging/php-master/maintenance/doMaintenance.php(99): UpdateMediaWiki->execute()
#7 /srv/mediawiki-staging/php-master/maintenance/update.php(270): require_once(string)
#8 /srv/mediawiki-staging/multiversion/MWScript.php(101): require_once(string)
#9 {main}

Details

SubjectRepoBranchLines +/-
wbterms: Add the foreign entities check in schema updater for property terms as wellmediawiki/extensions/Wikibasemaster+8 -0
Do not try to rebuild properties in case it's a foreign entitymediawiki/extensions/Wikibasemaster+9 -2
Customize query in gerrit

Related Objects

Event Timeline

Reedy created this task.Jan 20 2020, 3:40 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 20 2020, 3:40 PM
Reedy triaged this task as High priority.Jan 20 2020, 3:41 PM
Reedy added a project: MediaWiki-extensions-WikibaseRepository.Jan 20 2020, 3:44 PM
Reedy updated the task description. (Show Details)
Daimona mentioned this in T243219: session_name(): Cannot change session name when headers already sent in CommonSettings.php on line 510.Jan 20 2020, 3:51 PM
Ladsgroup edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)); removed Wikidata-Campsite.Jan 20 2020, 4:42 PM
Ladsgroup subscribed.Jan 20 2020, 4:54 PM

This happens because commons don't need this but we still try to run it on commons :( let me see if I can put a fix for this.

gerritbot added a comment.Jan 20 2020, 5:04 PM

Change 566072 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/Wikibase@master] Do not try to rebuild properties in case it's a foreign entity

https://gerrit.wikimedia.org/r/566072

gerritbot added a project: Patch-For-Review.Jan 20 2020, 5:05 PM
Ladsgroup claimed this task.Jan 20 2020, 5:06 PM
Ladsgroup moved this task from To Do (prioritised from top to bottom) to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptJan 20 2020, 5:06 PM
Maintenance_bot moved this task from incoming to in progress on the Wikidata board.Jan 20 2020, 5:15 PM
Maintenance_bot moved this task from Incoming to In progress on the User-Ladsgroup board.
WMDE-leszek mentioned this in T219144: wbterms: Register new terms store schema changes with MW update mechanism.Jan 21 2020, 10:42 AM
gerritbot added a comment.Jan 21 2020, 12:05 PM

Change 566072 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Do not try to rebuild properties in case it's a foreign entity

https://gerrit.wikimedia.org/r/566072

Maintenance_bot removed a project: Patch-For-Review.Jan 21 2020, 12:10 PM
gerritbot added a comment.Jan 21 2020, 12:50 PM

Change 566279 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/Wikibase@master] wbterms: Move the foreign entities check in schema updater to the right place

https://gerrit.wikimedia.org/r/566279

gerritbot added a project: Patch-For-Review.Jan 21 2020, 12:50 PM
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.16; 2020-01-21).Jan 21 2020, 1:00 PM
gerritbot added a comment.Jan 21 2020, 2:45 PM

Change 566279 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] wbterms: Add the foreign entities check in schema updater for property terms as well

https://gerrit.wikimedia.org/r/566279

Maintenance_bot removed a project: Patch-For-Review.Jan 21 2020, 3:10 PM
Ladsgroup added a comment.Jan 21 2020, 3:59 PM

It works now but it hangs in this:

...echo_event table does not contain event_page_namespace field.

I don't know what's wrong there :/

Ladsgroup moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jan 21 2020, 4:13 PM
Addshore closed this task as Resolved.Jan 22 2020, 10:17 AM
Ladsgroup moved this task from In progress to Done on the User-Ladsgroup board.Jan 22 2020, 10:27 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL