[21:32:52] <vanishedh> Can someone report an issue for me on phabricator? The issue is that in the MediaWiki API JS here https://doc.wikimedia.org/mediawiki-core/master/js/source/upload.html the fieldsAllowed variable is missing tags: true, so applying change tags with the upload function is not possible
https://commons.wikimedia.org/w/api.php?action=help&modules=upload shows we allow adding change tags
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| resources: Allow tags and watchlistexpiry params for upload via mw.Api | mediawiki/core | master | +2 -0 |
Adding that key won'd do anything as far as I know, given the Special:Upload form doesn't have this field.
Is this for a gadget? A third-party extension?
Honestly no idea. They wouldn't report the issue themselves, so it's hard to ask vanishedh what the actual use case was
I'm certainly not going to lose any sleep if this gets declined etc
Change #1216840 had a related patch set uploaded (by Umherirrender; author: Umherirrender):
[mediawiki/core@master] resources: Allow tags and watchlistexpiry params via mw.api.Upload
Added as part of 05c2c65ab9f4f30439de5282fe0d86384e8ae01a for the api and without UI part, use wpChangeTags form field in gadget to provide the change tags.
Api supports the tags paramter, so no need to block it via mw.Api
Change #1216840 merged by jenkins-bot:
[mediawiki/core@master] resources: Allow tags and watchlistexpiry params for upload via mw.Api