Page MenuHomePhabricator

Only save user settings if something has changed
Closed, ResolvedPublic

Description

LDAPUserInfo calls saveSettings()on \User object regardless of whether there is something different in the user info (which is usually not the case)

Make it only call saveSettings() when values actually changed.

Details

Related Gerrit Patches:
mediawiki/extensions/LDAPUserInfo : REL1_31Only save user settings when change is present
mediawiki/extensions/LDAPUserInfo : masterOnly save user settings when change is present

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 21 2020, 1:15 PM

Change 566282 had a related patch set uploaded (by ItSpiderman; owner: ItSpiderman):
[mediawiki/extensions/LDAPUserInfo@master] Only save user settings when change is present

https://gerrit.wikimedia.org/r/566282

Change 566511 had a related patch set uploaded (by ItSpiderman; owner: ItSpiderman):
[mediawiki/extensions/LDAPUserInfo@REL1_31] Only save user settings when change is present

https://gerrit.wikimedia.org/r/566511

Change 566282 merged by jenkins-bot:
[mediawiki/extensions/LDAPUserInfo@master] Only save user settings when change is present

https://gerrit.wikimedia.org/r/566282

Change 566511 merged by Robert Vogel:
[mediawiki/extensions/LDAPUserInfo@REL1_31] Only save user settings when change is present

https://gerrit.wikimedia.org/r/566511

Osnard closed this task as Resolved.Tue, Jan 28, 3:45 PM