Page MenuHomePhabricator

Rename ILanguageInterface::convert function to eliminate ambiguity
Open, LowPublic5 Estimated Story Points

Description

convert() is not a good name, convertToHtml() would be clearer.
If we change this, convertTo() should be changed as well.

rename convertTo to convertHtmlTo

Event Timeline

daniel added a comment.EditedJan 22 2020, 5:37 PM

If we want to do this, we should do it soon, before callers of Language::convert are changed to call LanguageConverter::convert.

Not a big priority though.

daniel renamed this task from Rename ILanguageInterface convertHtml function to eliminate ambiguity to Rename ILanguageInterface::convert function to eliminate ambiguity.Jan 22 2020, 5:38 PM
daniel triaged this task as Low priority.
daniel updated the task description. (Show Details)
Peter.ovchyn removed Peter.ovchyn as the assignee of this task.Feb 12 2020, 10:04 AM
Helga_sf set the point value for this task to 5.Apr 30 2020, 3:05 PM

Change 595341 had a related patch set uploaded (by Art-Baltai; owner: Art-Baltai):
[mediawiki/core@master] Rename ILanguageInterface::convert function to eliminate ambiguity

https://gerrit.wikimedia.org/r/595341

Art-Baltai updated the task description. (Show Details)May 12 2020, 1:18 AM
Helga_sf added a subscriber: Art-Baltai.
Helga_sf removed a subscriber: Art-Baltai.