Page MenuHomePhabricator

Create table with mapping between lang code and converter instead of using name convention
Closed, ResolvedPublic

Description

Actual:

	$className = $this->classNameFromCode( $code );
		if ( !class_exists( $className ) ) {

Expected:

$languages = ['uk' => UkConverter::class,
...
]
...
$converterClass = $languages[$code];

Details

Related Changes in Gerrit:

Event Timeline

Change 564789 had a related patch set uploaded (by Peter.ovchyn; owner: Peter.ovchyn):
[mediawiki/core@master] languages: Introduce LanguageConverterFactory (Work In Progress)

https://gerrit.wikimedia.org/r/564789

Looks to me like the initial patch is already doing this.

Change 564789 merged by jenkins-bot:
[mediawiki/core@master] languages: Introduce LanguageConverterFactory

https://gerrit.wikimedia.org/r/564789