Page MenuHomePhabricator
Create Task
Maniphest T243355

puppet panel: Can't add new prefixes
Closed, ResolvedPublic
Actions

Description

I wanted to add a deployment-puppetdb prefix in deployment-prep for T243226 to put hieradata in, but on form submission I just got redirected back to the project overview. Network tab shows this seems to be an auth problem:

image.png (99×876 px, 19 KB)

Details

ProjectBranchLines +/-Subject
openstack/horizon/deploytrain+1 -1Update wmf-puppet-dashboard submodule
openstack/horizon/wmf-puppet-dashboardtrain+2 -1Prefix tab: pass in self.request to render_to_string()
Customize query in gerrit

Related Objects

Event Timeline

Krenair created this task.Jan 21 2020, 10:54 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 21 2020, 10:54 PM
• JHedden added a subscriber: • JHedden.Jan 21 2020, 10:57 PM

Labweb logs show 2020-01-21 22:51:43.638032 Forbidden (CSRF token missing or incorrect.): /project/prefixpuppet/

Paladox added a subscriber: Paladox.Jan 21 2020, 10:57 PM
Andrew added a comment.Feb 3 2020, 7:30 PM

Yep, I can reproduce this and it's awful.

gerritbot added a comment.Feb 3 2020, 10:04 PM

Change 569656 had a related patch set uploaded (by Andrew Bogott; owner: Andrew Bogott):
[openstack/horizon/wmf-puppet-dashboard@train] Prefix tab: pass in self.request to render_to_string()

https://gerrit.wikimedia.org/r/569656

gerritbot added a project: Patch-For-Review.Feb 3 2020, 10:04 PM

Change 569656 merged by Andrew Bogott:
[openstack/horizon/wmf-puppet-dashboard@train] Prefix tab: pass in self.request to render_to_string()

https://gerrit.wikimedia.org/r/569656

gerritbot added a comment.Feb 3 2020, 10:07 PM

Change 569659 had a related patch set uploaded (by Andrew Bogott; owner: Andrew Bogott):
[openstack/horizon/deploy@train] Update wmf-puppet-dashboard submodule

https://gerrit.wikimedia.org/r/569659

gerritbot added a comment.Feb 3 2020, 10:08 PM

Change 569659 merged by Andrew Bogott:
[openstack/horizon/deploy@train] Update wmf-puppet-dashboard submodule

https://gerrit.wikimedia.org/r/569659

Maintenance_bot removed a project: Patch-For-Review.Feb 3 2020, 10:10 PM
Stashbot added a comment.Feb 3 2020, 10:14 PM

Mentioned in SAL (#wikimedia-operations) [2020-02-03T22:14:33Z] <andrew@deploy1001> Started deploy [horizon/deploy@8bffc7d]: Fix for T243355

Stashbot added a comment.Feb 3 2020, 10:18 PM

Mentioned in SAL (#wikimedia-operations) [2020-02-03T22:18:01Z] <andrew@deploy1001> Finished deploy [horizon/deploy@8bffc7d]: Fix for T243355 (duration: 03m 29s)

Andrew closed this task as Resolved.Feb 3 2020, 10:19 PM
Andrew claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL