Page MenuHomePhabricator

Disable progress bar in the phan docker image
Closed, DeclinedPublic

Description

In T219114 the phan progress bar was disabled after some debate. Half a year later, https://gerrit.wikimedia.org/r/541001 restored it without giving a good reason. Since the progress bar serves no purpose and only adds many useless lines to the log output, it can probably be disabled again by removing the -p switch in the phan command.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 22 2020, 10:40 AM

+1 to removing this progress bar from CI runs, It just looks ugly.

Daimona added a subscriber: Daimona.

Half a year later, https://gerrit.wikimedia.org/r/541001 restored it without giving a good reason.

That's not correct, see T219114#5822448 (which was mentioned in the commit message).

Also, note that the removal of the -p flag was proposed in r552164. After some discussions there, a new progress bar was implemented upstream. This one is more suitable for CI logs, as it's file-based, and not time-based. It can be enabled by using --long-progress-bar instead of -p. The reason it wasn't enabled immediately is that our docker image should be able to run phan for all extensions, regardless of the version of phan they have installed. Hence, we should add a check like:

if [ supports_long_progress_bar ]; then
    phan_opts=--long-progress-bar
else
    phan_opts=-p
fi

where supports_long_progress_bar can be implemented in various way. For instance, comparing the version of phan with 2.4.4, or grepping the output of phan --extended-help. Apparently, no progress was made since then.

Jdforrester-WMF closed this task as Declined.Mar 20 2020, 5:47 PM