Page MenuHomePhabricator
Create Task
Maniphest T243421

Increase SmashPig PHP minimum version to 7.0
Closed, ResolvedPublic
Actions

Description

7.0 may be EOL, but it's what we're running for a little bit longer. We can use it as a stepping stone and modernize halfway now instead of making even bigger changes on 7.2.

Add scalar type hints, return type declarations, and null coalesce when useful.

Update libraries.

Details

SubjectRepoBranchLines +/-
Return and argument types for config & contextwikimedia/fundraising/SmashPigmaster+36 -33
Add argument and return types to queue classeswikimedia/fundraising/SmashPigmaster+23 -17
Add more type hints, slight other cleanupwikimedia/fundraising/SmashPigmaster+59 -49
Update SmashPigDatabase and subclasses for php7wikimedia/fundraising/SmashPigmaster+87 -53
Update IListenerMessageAction::execute with return typewikimedia/fundraising/SmashPigmaster+12 -12
Use PSR-12 standard spacing for return typeswikimedia/fundraising/SmashPigmaster+41 -41
Add type hints and return types to Ingenico classeswikimedia/fundraising/SmashPigmaster+51 -45
Update minimum PHP version and PHPUnit versionwikimedia/fundraising/SmashPigmaster+107 -52
Customize query in gerrit

Event Timeline

Ejegg created this task.Jan 22 2020, 2:52 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 22 2020, 2:52 PM
• DStrine moved this task from Triage to Q3 2021-2022 on the Fundraising-Backlog board.Feb 3 2020, 9:21 PM
gerritbot added a comment.Mar 6 2020, 10:45 PM

Change 577686 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[wikimedia/fundraising/SmashPig@master] Update minimum PHP version and PHPUnit version

https://gerrit.wikimedia.org/r/577686

gerritbot added a project: Patch-For-Review.Mar 6 2020, 10:45 PM
gerritbot added a comment.Mar 6 2020, 11:21 PM

Change 577686 merged by jenkins-bot:
[wikimedia/fundraising/SmashPig@master] Update minimum PHP version and PHPUnit version

https://gerrit.wikimedia.org/r/577686

Maintenance_bot removed a project: Patch-For-Review.Mar 7 2020, 12:10 AM
gerritbot added a comment.Mar 20 2020, 8:40 PM

Change 582170 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[wikimedia/fundraising/SmashPig@master] Add type hints and return types to Ingenico classes

https://gerrit.wikimedia.org/r/582170

gerritbot added a project: Patch-For-Review.Mar 20 2020, 8:40 PM
gerritbot added a comment.Mar 24 2020, 1:03 AM

Change 582170 merged by jenkins-bot:
[wikimedia/fundraising/SmashPig@master] Add type hints and return types to Ingenico classes

https://gerrit.wikimedia.org/r/582170

Maintenance_bot removed a project: Patch-For-Review.Mar 24 2020, 1:10 AM
gerritbot added a comment.Mar 27 2020, 4:23 PM

Change 584002 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[wikimedia/fundraising/SmashPig@master] Update IListenerMessageAction::execute with return type

https://gerrit.wikimedia.org/r/584002

gerritbot added a project: Patch-For-Review.Mar 27 2020, 4:23 PM
gerritbot added a comment.Mar 27 2020, 4:40 PM

Change 584013 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[wikimedia/fundraising/SmashPig@master] Update SmashPigDatabase and subclasses for php7

https://gerrit.wikimedia.org/r/584013

gerritbot added a comment.Mar 27 2020, 10:01 PM

Change 584067 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[wikimedia/fundraising/SmashPig@master] Add more type hints, slight other cleanup

https://gerrit.wikimedia.org/r/584067

gerritbot added a comment.Mar 30 2020, 10:28 PM

Change 584719 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[wikimedia/fundraising/SmashPig@master] Add argument and return types to queue classes

https://gerrit.wikimedia.org/r/584719

gerritbot added a comment.Mar 30 2020, 11:05 PM

Change 584730 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[wikimedia/fundraising/SmashPig@master] Return and argument types for config & context

https://gerrit.wikimedia.org/r/584730

gerritbot added a comment.Apr 22 2020, 11:09 PM

Change 592109 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[wikimedia/fundraising/SmashPig@master] Use PSR-12 standard spacing for return types

https://gerrit.wikimedia.org/r/592109

gerritbot added a comment.Apr 28 2020, 6:09 PM

Change 592109 merged by jenkins-bot:
[wikimedia/fundraising/SmashPig@master] Use PSR-12 standard spacing for return types

https://gerrit.wikimedia.org/r/592109

gerritbot added a comment.Apr 29 2020, 9:04 PM

Change 584002 merged by jenkins-bot:
[wikimedia/fundraising/SmashPig@master] Update IListenerMessageAction::execute with return type

https://gerrit.wikimedia.org/r/584002

gerritbot added a comment.Apr 29 2020, 9:08 PM

Change 584013 merged by jenkins-bot:
[wikimedia/fundraising/SmashPig@master] Update SmashPigDatabase and subclasses for php7

https://gerrit.wikimedia.org/r/584013

gerritbot added a comment.May 8 2020, 3:51 PM

Change 584067 merged by jenkins-bot:
[wikimedia/fundraising/SmashPig@master] Add more type hints, slight other cleanup

https://gerrit.wikimedia.org/r/584067

gerritbot added a comment.May 8 2020, 3:51 PM

Change 584719 merged by jenkins-bot:
[wikimedia/fundraising/SmashPig@master] Add argument and return types to queue classes

https://gerrit.wikimedia.org/r/584719

gerritbot added a comment.May 8 2020, 3:52 PM

Change 584730 merged by jenkins-bot:
[wikimedia/fundraising/SmashPig@master] Return and argument types for config & context

https://gerrit.wikimedia.org/r/584730

Maintenance_bot removed a project: Patch-For-Review.May 8 2020, 4:10 PM
Ejegg closed this task as Resolved.Aug 8 2022, 5:43 PM
Ejegg claimed this task.
Ejegg triaged this task as Medium priority.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL