I'm pretty sure that in the 'guided' mode all hiera values or params are interpreted as strings, including e.g. true and false.
I'm told that it might work properly in the yaml UI but I need to double-check.
Description
Description
Details
Details
Customize query in gerrit
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T294906 Puppet Improvements 2021/2022 | |||
| Open | None | T285539 Easing pain points caused by divergence between cloudservices and production puppet usecases | |||
| Open | None | T161675 Re-think puppet management for deployment-prep | |||
| Resolved | Andrew | T243422 Horizon hiera UI: investigate data type handling |
Event Timeline
Comment Actions
I've confirmed that the behavior with the yaml-based UI is correct. For the guided interface, strings are unquoted and non-string types (numbers, booleans, etc.) are quoted. weird.
Comment Actions
This is happening because yaml.safe_dump() (and yaml.dump()) does some weird arbitrary quoting of things:
>>> testdict
{'role::puppetmaster::standalone::autosign': 'True', 'role::puppetmaster::standalone::command_broadcast': 'false', 'role::puppetmaster::standalone::puppetdb_host': 'blahblah', 'role::puppetmaster::standalone::git_sync_minutes': '11', 'role::labs::lvm::mnt::mount_point': '/arbitrarier'}
>>>
>>>
>>> yaml.dump(testdict)
"{'role::labs::lvm::mnt::mount_point': /arbitrarier, 'role::puppetmaster::standalone::autosign': 'True',\n 'role::puppetmaster::standalone::command_broadcast': 'false', 'role::puppetmaster::standalone::git_sync_minutes': '11',\n 'role::puppetmaster::standalone::puppetdb_host': blahblah}\n"In theory specifying default_style=None should stop it quoting things, but it doesn't.
Comment Actions
Change 570741 had a related patch set uploaded (by Andrew Bogott; owner: Andrew Bogott):
[openstack/horizon/wmf-puppet-dashboard@train] puppet_config: detect some parameter types
Comment Actions
Change 570748 had a related patch set uploaded (by Andrew Bogott; owner: Andrew Bogott):
[openstack/horizon/wmf-puppet-dashboard@master] puppet_config: detect some parameter types
Comment Actions
Change 570741 abandoned by Andrew Bogott:
puppet_config: detect some parameter types
Reason:
this should be a cherry pick
Comment Actions
Change 570748 merged by Andrew Bogott:
[openstack/horizon/wmf-puppet-dashboard@master] puppet_config: detect some parameter types
Comment Actions
Change 570914 had a related patch set uploaded (by Andrew Bogott; owner: Andrew Bogott):
[openstack/horizon/wmf-puppet-dashboard@train] puppet_config: detect some parameter types
Comment Actions
Change 570914 merged by Andrew Bogott:
[openstack/horizon/wmf-puppet-dashboard@train] puppet_config: detect some parameter types
Comment Actions
Change 570915 had a related patch set uploaded (by Andrew Bogott; owner: Andrew Bogott):
[openstack/horizon/deploy@train] Update wmf-puppet-dashboard submodule
Comment Actions
Change 570915 merged by Andrew Bogott:
[openstack/horizon/deploy@train] Update wmf-puppet-dashboard submodule
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2020-02-07T16:01:58Z] <andrew@deploy1001> Started deploy [horizon/deploy@bc777d6]: Fix for T243422
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2020-02-07T16:05:43Z] <andrew@deploy1001> Finished deploy [horizon/deploy@bc777d6]: Fix for T243422 (duration: 03m 45s)