Page MenuHomePhabricator

TwoColumnConflict preview passes incorrect namespace to templates
Closed, ResolvedPublic3 Estimated Story Points

Description

  • I encountered an edit conflict at English Wikipedia:Village_pump_(policy), with the beta edit conflict software enabled.
  • The page included several copies of the the Talk Quote template, {{tq}}. This template includes logic to verify the namespace of the current page. This template generates a red error message when it detects that it is being used on an inappropriate page. The template normally detects and accepts Village Pump as an appropriate page.
  • The {{tq}} template failed to render correctly in the beta edit conflict preview. The template generated warning messages that it was being used on an inappropriate page.
  • I saved the edit. The template and everything else rendered correctly on the saved page.

I believe the most likely explanation is that the edit conflict software passed incorrect information about the page to the template logic. I only encountered this issue once, I was in the middle of clicking save when I spotted the problem, and I have not attempted any testing. My interpretation and explanation of the issue seem obvious and simple, but it is merely a hasty hypothesis.

Event Timeline

Change 566698 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/TwoColConflict@master] Fix preview always being shown in article context

https://gerrit.wikimedia.org/r/566698

Change 566698 merged by jenkins-bot:
[mediawiki/extensions/TwoColConflict@master] Fix preview always being shown in article context

https://gerrit.wikimedia.org/r/566698

awight added a subscriber: awight.

We found the same bug in Special:SimulateTwoColConflict after "simulate publishing changes", by using the {{FULLPAGENAME}} substitution. The namespace was missing from the title. Did not smoke test the bug as reported here, yet.

Change 570006 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/TwoColConflict@master] Fix conflict simulation forgetting about the namespace

https://gerrit.wikimedia.org/r/570006

awight renamed this task from Preview problem in the beta Edit Conflict software - might be mishandling of page info passed to template logic to TwoColumnConflict preview passes incorrect namespace to templates.Feb 6 2020, 12:19 PM
awight claimed this task.
awight moved this task from Demo to Done on the WMDE-QWERTY-Sprint-2020-02-04 board.

Verified by smoke testing on enwiki.

Change 570006 merged by jenkins-bot:
[mediawiki/extensions/TwoColConflict@master] Fix conflict simulation forgetting about the namespace

https://gerrit.wikimedia.org/r/570006