Error: "Call to a member function getName() on null" (from GrowthExperiments Mentorship.php)
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error

MediaWiki version: 1.35.0-wmf.15

message

Error: Call to a member function getName() on null

exception.trace

#0 /srv/mediawiki/php-1.35.0-wmf.15/extensions/GrowthExperiments/includes/HomepageModules/Mentorship.php(67): GrowthExperiments\HomepageModules\Mentorship->getMentorUsernameElement(boolean)
#1 /srv/mediawiki/php-1.35.0-wmf.15/extensions/GrowthExperiments/includes/HomepageModules/BaseModule.php(142): GrowthExperiments\HomepageModules\Mentorship->getBody()
#2 /srv/mediawiki/php-1.35.0-wmf.15/extensions/GrowthExperiments/includes/HomepageModules/BaseModule.php(75): GrowthExperiments\HomepageModules\BaseModule->renderMobileDetailsForOverlay()
#3 /srv/mediawiki/php-1.35.0-wmf.15/extensions/GrowthExperiments/includes/Specials/SpecialHomepage.php(377): GrowthExperiments\HomepageModules\BaseModule->getJsData(string)
#4 /srv/mediawiki/php-1.35.0-wmf.15/extensions/GrowthExperiments/includes/Specials/SpecialHomepage.php(174): GrowthExperiments\Specials\SpecialHomepage->outputJsData(string, array)
#5 /srv/mediawiki/php-1.35.0-wmf.15/includes/specialpage/SpecialPage.php(575): GrowthExperiments\Specials\SpecialHomepage->execute(NULL)
#6 /srv/mediawiki/php-1.35.0-wmf.15/includes/specialpage/SpecialPageFactory.php(611): SpecialPage->run(NULL)
#7 /srv/mediawiki/php-1.35.0-wmf.15/includes/MediaWiki.php(298): MediaWiki\Special\SpecialPageFactory->executePath(Title, RequestContext)
#8 /srv/mediawiki/php-1.35.0-wmf.15/includes/MediaWiki.php(967): MediaWiki->performRequest()
#9 /srv/mediawiki/php-1.35.0-wmf.15/includes/MediaWiki.php(530): MediaWiki->main()
#10 /srv/mediawiki/php-1.35.0-wmf.15/index.php(46): MediaWiki->run()
#11 /srv/mediawiki/w/index.php(3): require(string)
#12 {main}

Details

Request ID: XiiiTwpAAD8AAEMwWhcAAABD
Request URL: https://ar.m.wikipedia.org/w/index.php?title=…&source=specialcontributions

	Subject	Repo	Branch	Lines +/-
	Do not call render methods when the module might not be set up	mediawiki/extensions/GrowthExperiments	master	+27 -7

Customize query in gerrit

Related Objects

Mentioned Here: rEGRE7c36ad586104: Allow modules to export arbitrary module data, not just overlays

Event Timeline

Etonkovidova created this task.Jan 22 2020, 7:42 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 22 2020, 7:42 PM

Aklapper added a project: GrowthExperiments-Homepage.Jan 22 2020, 9:48 PM

Probably caused by rEGRE7c36ad586104: Allow modules to export arbitrary module data, not just overlays. Not too serious as it only affects users with no mentor, but it's a production error so let's get it fixed soon.

Change 566632 had a related patch set uploaded (by Gergő Tisza; owner: Gergő Tisza):
[mediawiki/extensions/GrowthExperiments@master] Do not call render methods when the module might not be set up

https://gerrit.wikimedia.org/r/566632

gerritbot added a project: Patch-For-Review.Jan 23 2020, 1:12 AM

Tgr moved this task from Incoming to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.Jan 23 2020, 1:21 AM

Change 566632 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Do not call render methods when the module might not be set up

https://gerrit.wikimedia.org/r/566632

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.18; 2020-02-04).Jan 23 2020, 2:00 AM

Maintenance_bot removed a project: Patch-For-Review.Jan 23 2020, 2:10 AM

Krinkle renamed this task from wmf.15/extensions/GrowthExperiments/includes/HomepageModules/Mentorship.php: Call to a member function getName() on null to Error: "Call to a member function getName() on null" (from GrowthExperiments Mentorship.php).Jan 23 2020, 11:51 AM

Krinkle changed Request URL from https://ar.wikipedia.org/w/index.php?title=%D8%AE%D8%A7%D8%B5:%D8%B5%D9%81%D8%AD%D8%A9_%D8%B1%D8%A6%D9%8A%D8%B3%D9%8A%D8%A9&source=specialcontributions to https://ar.m.wikipedia.org/w/index.php?title=…&source=specialcontributions.

Krinkle updated the task description. (Show Details)

Krinkle edited Stack Trace. (Show Details)

Krinkle moved this task from Untriaged to Jan2020/1.35-wmf.14 on the Wikimedia-production-error board.

kostajh moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Jan 24 2020, 12:27 PM

Etonkovidova added a project: User-Etonkovidova.Feb 11 2020, 5:54 PM

Etonkovidova moved this task from Incoming to Need to follow up on the User-Etonkovidova board.

Checked in wmf.18.

Error: "Call to a member function getName() on null" (from GrowthExperiments Mentorship.php)Closed, ResolvedPublicPRODUCTION ERRORActions