Phab Global Search broken: Unhandled Exception: Argument 1 passed to PhabricatorHandleQuery::withPHIDs() must be of the type array, object given
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Xaosflux
	Jan 23 2020, 3:44 AM

Description

Steps to reproduce:
Try to search for anything in the Global Phabricator search

Expected response: results

Actual response, the following errors:

Unhandled Exception ("TypeError")
Unhandled Exception ("TypeError")
Argument 1 passed to PhabricatorHandleQuery::withPHIDs() must be of the type array, object given, called in /srv/deployment/phabricator/deployment-cache/revs/4547f31de8f69854e0cd9d3e0a802ce517360ee0/phabricator/src/applications/search/query/PhabricatorSearchDocumentQuery.php on line 61

Workaround:
Don't use the global search but an application specific search, e.g. https://phabricator.wikimedia.org/maniphest/query/advanced/ for Maniphest tasks.

Related Objects

Mentioned In: T243483: Unknown search function "XXX". Supported functions are: all, title, body, core, comment.
Mentioned Here: rPHAB60759f2ef9d5: PhabricatorSearchService::newResultSet should return…
T230787: Make search context highlights work with the ferret search engine
rPHDEP4547f31de8f6: Updated submodules for release/2019-08-21/1

Event Timeline

Xaosflux created this task.Jan 23 2020, 3:44 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 23 2020, 3:44 AM

Xaosflux renamed this task from Searching in phabricator are failing to Searchs in phabricator are failing with Unhandled Exception.Jan 23 2020, 3:45 AM

Xaosflux renamed this task from Searchs in phabricator are failing with Unhandled Exception to Searches in phabricator are failing with Unhandled Exception.

Started happening during the Phab upgrade today. Affects the generic search but not Maniphest search.

If you search for ticket numbers (e.g., 'T243479'), then you can reach the corresponding ticket - but no free text searching it seems.

jcrespo mentioned this in T243483: Unknown search function "XXX". Supported functions are: all, title, body, core, comment..Jan 23 2020, 10:04 AM

dcausse subscribed.Jan 23 2020, 10:07 AM

(For future reference, clear and exact steps to reproduce with URLs are welcome. Phabricator has several searches. See https://www.mediawiki.org/wiki/How_to_report_a_bug )

https://phabricator.wikimedia.org/search/ prints that error too.

Wondering if this could be related to T230787 stuff

Aklapper renamed this task from Searches in phabricator are failing with Unhandled Exception to Phab Global Search broken: Unhandled Exception: Argument 1 passed to PhabricatorHandleQuery::withPHIDs() must be of the type array, object given.Jan 23 2020, 10:39 AM

Aklapper triaged this task as High priority.

Aklapper updated the task description. (Show Details)

Aklapper added a subscriber: • mmodell.

Amorymeltzer subscribed.Jan 23 2020, 11:07 AM

Daimona subscribed.Jan 23 2020, 11:08 AM

Krinkle subscribed.Jan 23 2020, 11:34 AM

The file is at https://phabricator.wikimedia.org/source/phabricator/browse/wmf%252Fstable/src/applications/search/query/PhabricatorSearchDocumentQuery.php;9a65bc28eca29f6bdbb29cc5dccd97d879378f3b

Looking at the history the sole recentish change is:

https://phabricator.wikimedia.org/rPHAB60759f2ef9d5a7e74894695634d47b27da205ff5

So maybe it is sufficient to revert that one, but that might have side effects.

This seems to also break fetching results in the "Edit Parent Tasks" and "Edit Parent Tasks" dialogs, which makes this UBN to me.

Restricted Application added a subscriber: Liuxinyu970226. · View Herald TranscriptJan 23 2020, 12:01 PM

• mmodell closed this task as Resolved by committing rPHAB8a99d78f5b88: Move the construction of PhabricatorFulltextResultSet into the Fulltext Storage….Jan 23 2020, 12:29 PM

• mmodell claimed this task.

Mentioned in SAL (#wikimedia-operations) [2020-01-23T12:31:33Z] <twentyafterfour> Deploying hotfix for T243479, restarting php7.3-fpm on phab1003

• mmodell edited projects, added Phabricator (2020-01-23); removed Phabricator.Jan 23 2020, 5:02 PM

Phab Global Search broken: Unhandled Exception: Argument 1 passed to PhabricatorHandleQuery::withPHIDs() must be of the type array, object givenClosed, ResolvedPublicActions

Description

Related Objects

Event Timeline

Phab Global Search broken: Unhandled Exception: Argument 1 passed to PhabricatorHandleQuery::withPHIDs() must be of the type array, object given
Closed, ResolvedPublic
Actions