Page MenuHomePhabricator
Create Task
Maniphest T243492

RunSingleJob: MediaWiki::restInPeace: transaction round 'LinksUpdate::doUpdate' still running
Closed, DuplicatePublic
Actions

Description

Seeing this in the logs. It looks like some of the last LoadBalancer-related shutdown or commit errors in the logs (I've been trying to clear this out as an OKR).

/rpc/RunSingleJob.php   Wikimedia\Rdbms\DBTransactionError from line 258 of /srv/mediawiki/php-1.35.0-wmf.15/includes/libs/rdbms/lbfactory/LBFactory.php: MediaWiki::restInPeace: transaction round 'LinksUpdate::doUpdate' still running

I notice that JobRunner and JobExecutor are still a bit out of sync, so that might be a good starting place.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
jobqueue: cleanup JobRunner for reability and code reusemediawiki/coremaster+125 -79
Customize query in gerrit

Related Objects

Event Timeline

aaron created this task.Jan 23 2020, 9:18 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 23 2020, 9:18 AM
gerritbot added a comment.Jan 23 2020, 9:19 AM

Change 566691 had a related patch set uploaded (by Aaron Schulz; owner: Aaron Schulz):
[mediawiki/core@master] jobqueue: cleanup JobRunner for reability and code reuse

https://gerrit.wikimedia.org/r/566691

gerritbot added a project: Patch-For-Review.Jan 23 2020, 9:19 AM
Krinkle subscribed.Jan 29 2020, 4:14 AM
Patch by @aaron at https://gerrit.wikimedia.org/r/566691:

jobqueue: cleanup JobRunner for reability and code reuse

The intended use case for this method is JobExecutor. Calling
this method from there could cut down on code duplication.

Cross-ref for general awareness
T220127: Reuse JobExecutor within a JobRunner,
T175146: JobQueue: Unify JobRunner entry points.

gerritbot added a comment.Jan 29 2020, 9:17 PM

Change 566691 merged by jenkins-bot:
[mediawiki/core@master] jobqueue: cleanup JobRunner for reability and code reuse

https://gerrit.wikimedia.org/r/566691

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.18; 2020-02-04).Jan 29 2020, 10:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jan 29 2020, 10:10 PM
Krinkle removed a project: MW-1.35-notes (1.35.0-wmf.18; 2020-02-04).Feb 3 2020, 9:17 PM
• Gilles assigned this task to aaron.Feb 3 2020, 9:17 PM
• Gilles moved this task from Inbox, needs triage to Doing (old) on the Performance-Team board.
Krinkle moved this task from Untriaged to Core on the WMF-JobQueue board.Mar 6 2020, 11:09 PM
Krinkle closed this task as a duplicate of T228911: DBTransactionError "transaction round 'LinksUpdate::doUpdate' still running" (via RunSingleJob.php).
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits