Page MenuHomePhabricator

RunSingleJob: MediaWiki::restInPeace: transaction round 'LinksUpdate::doUpdate' still running
Closed, DuplicatePublic

Description

Seeing this in the logs. It looks like some of the last LoadBalancer-related shutdown or commit errors in the logs (I've been trying to clear this out as an OKR).

/rpc/RunSingleJob.php   Wikimedia\Rdbms\DBTransactionError from line 258 of /srv/mediawiki/php-1.35.0-wmf.15/includes/libs/rdbms/lbfactory/LBFactory.php: MediaWiki::restInPeace: transaction round 'LinksUpdate::doUpdate' still running

I notice that JobRunner and JobExecutor are still a bit out of sync, so that might be a good starting place.

Event Timeline

Change 566691 had a related patch set uploaded (by Aaron Schulz; owner: Aaron Schulz):
[mediawiki/core@master] jobqueue: cleanup JobRunner for reability and code reuse

https://gerrit.wikimedia.org/r/566691

jobqueue: cleanup JobRunner for reability and code reuse

The intended use case for this method is JobExecutor. Calling
this method from there could cut down on code duplication.

Cross-ref for general awareness
T220127: Reuse JobExecutor within a JobRunner,
T175146: [RfC] Move RunJobs.php to the mediawiki (core) repository.

Change 566691 merged by jenkins-bot:
[mediawiki/core@master] jobqueue: cleanup JobRunner for reability and code reuse

https://gerrit.wikimedia.org/r/566691