Use ObjectFactory to construct ContentHandlers
Closed, ResolvedPublic
Actions

Description

ContentHandlersFactory should have the contents of $wgContentHandlers injected as a constructor parameter, along with an ObjectFactory. SpecialPageFactory can be taken as a model. Note however that SpecialPageFactory maintains the list of specs in a local constant, while the default specs for ContentHandlers as placed in $wgContentHandlers in DefaultSettings.php.

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/core	master	+22 -4	registration: Allow ObjectFactory spec in extension.json schema
	mediawiki/core	master	+409 -93	Use ObjectFactory to construct ContentHandlers

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	Peter.ovchyn	T226832 Deprecate Language::convertTitle(), findVariantLink(), updateConversionTable(), and friends
Resolved	Peter.ovchyn	T226833 Introduce LanguageConverterFactory service
Open	None	T243310 Once we have ContentHandlerFactory, we can think about injecting the LanguageConverterFactory into ContentHandler.
Resolved	Art-Baltai	T235165 Introduce ContentHandlerFactory
Resolved	Art-Baltai	T243560 Use ObjectFactory to construct ContentHandlers

Event Timeline

daniel created this task.Jan 23 2020, 10:42 PM

daniel added a parent task: T243310: Once we have ContentHandlerFactory, we can think about injecting the LanguageConverterFactory into ContentHandler..

daniel mentioned this in T243310: Once we have ContentHandlerFactory, we can think about injecting the LanguageConverterFactory into ContentHandler..Jan 23 2020, 10:46 PM

kchapman moved this task from Backlog to Estimated/Estimation on the Platform Team Workboards (S&F Workboard) board.Jan 24 2020, 5:35 PM

Art-Baltai moved this task from Estimated/Estimation to In Progress/Doing on the Platform Team Workboards (S&F Workboard) board.Jan 27 2020, 11:46 PM

Change 568491 had a related patch set uploaded (by Art-Baltai; owner: Art-Baltai):
[mediawiki/core@master] component: Use ObjectFactory to construct ContentHandlers

https://gerrit.wikimedia.org/r/568491

gerritbot added a project: Patch-For-Review.Jan 29 2020, 1:45 PM

Art-Baltai moved this task from In Progress/Doing to In Progress/In Review on the Platform Team Workboards (S&F Workboard) board.Jan 29 2020, 3:01 PM

Art-Baltai added a project: Platform Engineering.

Change 568491 abandoned by Art-Baltai:
component: Use ObjectFactory to construct ContentHandlers

Reason:
actual is: https://gerrit.wikimedia.org/r/c/mediawiki/core/ /566276

https://gerrit.wikimedia.org/r/568491

Maintenance_bot removed a project: Patch-For-Review.Feb 5 2020, 4:10 PM

daniel removed a project: Platform Engineering.Feb 5 2020, 7:28 PM

Change 568491 restored by Art-Baltai:
component: Use ObjectFactory to construct ContentHandlers

https://gerrit.wikimedia.org/r/568491

Change 568491 merged by jenkins-bot:
[mediawiki/core@master] Use ObjectFactory to construct ContentHandlers