Page MenuHomePhabricator

VideoCutTool pending tasks to release version 0.2
Closed, ResolvedPublic

Description

VideoCutTool is a tool to trim, crop, rotate on-the-fly videos in Wikimedia Commons. It is hosted in Wikimedia Toolforge and can be found at https://tools.wmflabs.org/video-cut-tool/

  • In Step-2 progress bar for the video encodings is not working in the production but working fine in the local system. - T277369: Format and refactor VideoCutTools worker and add progress bar
  • Newly generated video uploading to commons is failing and the server is going down server logs: https://pastebin.com/4Ekfj90v
  • The progress bar should be placed above "Player" Currently it is placed here: https://ibb.co/nPc9pG3 t
  • After clicking on "Upload to commons" button while the process is on progress. The button has to become non-clickable to avoid multiple taps by the user.
  • In step-3 at the below the player the response of the new Uploaded video URL states "Your video is uploaded here:...." is returning old file name/title, It should return a new uploaded video title (a new title which is given in the upload section).
  • In Step-3, the "Download" button is not working in the production.
  • Ask for the licensing information in step-3 while uploading a new video from VideoCutTool.

Code repos:

Event Timeline

Hi, @Crutishnyk Thanks for claiming this ticket, If you noticed anything unclear in this task please feel free to post your questions :)

Now I'm doing the last point of this ticket, here how it looks on my local machine. Is it okay?

Аннотация 2020-01-25 160400.png (923×1 px, 68 KB)

Good work, few minor changes are needed:

  • In step-3 overwrite file is not working, As If the user taps on Overwrite the filename should not append _(edited). If the filename is the same then the video will be overwritten to the newer version.
  • Uploading is done successfully but I got the notification Something went wrong that should result saying Uploaded Successfully
  • "Your video is uploaded here: <>" link should display above the player.

Uploading is done successfully but I got the notification Something went wrong that should result saying Uploaded Successfully

Do you have any steps to reproduce or logs?

I didn't find anything suspicious in logs, After uploading file everything is similar to these logs which we discussed yesterday in IRC https://pastebin.com/eGK7qNFU but I noticed "Something went wrong".

Managed to reproduce this error, fixed.
Updated both pull requests.

My thought about progress bar in step 2: I want to believe that it is not working in production because all video editing progress now are listening via stderr channel which is not empty on local machine, but it's empty in production.
Uploaded a PR with fix at https://github.com/gopavasanth/video-cut-tool-back-end/pull/14

Hi @Crutishnyk, I just tested your new patch in production, for video encodings progress bar is not working in production due to some unknown reason :|

Change 569937 had a related patch set uploaded (by Crutishnyk; owner: Crutishnyk):
[labs/tools/VideoCutTool@master] components/home: Add spinner for on video encoding process

https://gerrit.wikimedia.org/r/569937

Change 569937 merged by Gopavasanth:
[labs/tools/VideoCutTool@master] components/home: Add spinner for on video encoding process

https://gerrit.wikimedia.org/r/569937

Gopavasanth updated the task description. (Show Details)