Page MenuHomePhabricator
Create Task
Maniphest T243594

Enable disabled phan checks in Wikibase
Closed, ResolvedPublic
Actions

Description

In addition to T217425, currently disabled phan checks 'scalar_implicit_cast' and 'null_casts_as_any_type' should be enabled in Wikibase, too.

A first patch for testing purposes generated 105 phan errors in the jenkins build pipeline. See https://integration.wikimedia.org/ci/job/mwext-php72-phan-docker/32744/console#console-section-0

Details

SubjectRepoBranchLines +/-
phan: Disable null_casts_as_any_type settingmediawiki/extensions/Wikibasemaster+67 -18
build: Enable PhanTypeMismatchReturn and make passmediawiki/extensions/Wikibasemaster+11 -11
build: Enable PhanPluginSimplifyExpressionBool and make passmediawiki/extensions/Wikibasemaster+4 -5
build: Enable PhanPluginNeverReturnMethod and make passmediawiki/extensions/Wikibasemaster+40 -2
build: Disable phan option scalar_implicit_cast and make passmediawiki/extensions/Wikibasemaster+15 -8
Enable disabled phan checksmediawiki/extensions/Wikibasemaster+5 -5
Add Elastica stubs to avoid phan errorsmediawiki/extensions/Wikibasemaster+31 -1
Customize query in gerrit

Related Objects

Event Timeline

Silvan_WMDE created this task.Jan 24 2020, 12:44 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 24 2020, 12:44 PM
Addshore subscribed.Jan 24 2020, 12:45 PM
Silvan_WMDE edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)); removed Wikidata-Campsite.Jan 24 2020, 12:45 PM
Silvan_WMDE moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Maintenance_bot moved this task from incoming to in progress on the Wikidata board.Jan 24 2020, 1:15 PM
Silvan_WMDE updated the task description. (Show Details)Jan 27 2020, 10:12 AM
Silvan_WMDE updated the task description. (Show Details)Jan 27 2020, 10:34 AM
Silvan_WMDE updated the task description. (Show Details)Jan 27 2020, 11:34 AM
Silvan_WMDE updated the task description. (Show Details)Jan 28 2020, 10:58 AM
Silvan_WMDE moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jan 28 2020, 11:01 AM
This comment was removed by Silvan_WMDE.
gerritbot added a comment.Jan 29 2020, 12:20 PM

Change 568470 had a related patch set uploaded (by Silvan Heintze; owner: Silvan Heintze):
[mediawiki/extensions/Wikibase@master] Enable disabled phan checks

https://gerrit.wikimedia.org/r/568470

gerritbot added a project: Patch-For-Review.Jan 29 2020, 12:20 PM
Silvan_WMDE removed a project: Patch-For-Review.Jan 29 2020, 12:31 PM
Silvan_WMDE updated the task description. (Show Details)
Silvan_WMDE removed Silvan_WMDE as the assignee of this task.Jan 29 2020, 12:51 PM
Silvan_WMDE moved this task from Wikidata-Campsite-Iteration-∞ (On Hold) to Incoming on the Wikidata-Campsite board.
Silvan_WMDE edited projects, added Wikidata-Campsite; removed Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)).
Silvan_WMDE unsubscribed.
Addshore moved this task from Incoming to Needs Tech Work on the Wikidata-Campsite board.Jan 29 2020, 2:44 PM
gerritbot added a comment.Feb 3 2020, 2:40 PM

Change 569550 had a related patch set uploaded (by Silvan Heintze; owner: Silvan Heintze):
[mediawiki/extensions/Wikibase@master] Add Elastica stubs to avoid phan errors

https://gerrit.wikimedia.org/r/569550

gerritbot added a project: Patch-For-Review.Feb 3 2020, 2:40 PM
Silvan_WMDE added a comment.Feb 3 2020, 2:47 PM

Moved stub changes from https://gerrit.wikimedia.org/r/568470 to separate patch https://gerrit.wikimedia.org/r/569550, so that they can be merged independently from the (currently still failing) phan config change.

gerritbot added a comment.Feb 3 2020, 7:12 PM

Change 569550 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Add Elastica stubs to avoid phan errors

https://gerrit.wikimedia.org/r/569550

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.18; 2020-02-04).Feb 3 2020, 8:00 PM
Addshore removed projects: Wikidata-Campsite, good first task.Feb 6 2020, 9:29 AM

Not going to be a campsite priority so removing it

Silvan_WMDE subscribed.Feb 26 2020, 9:12 AM
gerritbot added a comment.Oct 12 2020, 5:00 PM

Change 568470 abandoned by Silvan Heintze:
[mediawiki/extensions/Wikibase@master] Enable disabled phan checks

Reason:
old and never followed up

https://gerrit.wikimedia.org/r/568470

Umherirrender edited projects, added phan; removed Patch-For-Review.Mar 28 2022, 9:12 PM
Umherirrender moved this task from Backlog to Extensions on the phan board.Mar 31 2022, 5:53 PM
Umherirrender mentioned this in T316575: SecurePoll's phan CI has been configured such that it did not catch a missing comma.Aug 30 2022, 7:34 PM
gerritbot added a comment.Apr 12 2023, 8:34 PM

Change 908347 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Wikibase@master] build: Disable phan option scalar_implicit_cast and make pass

https://gerrit.wikimedia.org/r/908347

gerritbot added a project: Patch-For-Review.Apr 12 2023, 8:34 PM
gerritbot added a comment.Apr 13 2023, 2:02 PM

Change 908347 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] build: Disable phan option scalar_implicit_cast and make pass

https://gerrit.wikimedia.org/r/908347

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.5; 2023-04-17).Apr 13 2023, 3:00 PM
gerritbot added a comment.Apr 13 2023, 3:25 PM

Change 908583 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Wikibase@master] phan: Disable null_casts_as_any_type setting

https://gerrit.wikimedia.org/r/908583

gerritbot added a comment.Apr 13 2023, 4:05 PM

Change 908591 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Wikibase@master] build: Enable PhanTypeMismatchReturn and make pass

https://gerrit.wikimedia.org/r/908591

gerritbot added a comment.Apr 13 2023, 6:10 PM

Change 908610 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Wikibase@master] build: Enable PhanPluginNeverReturnMethod and make pass

https://gerrit.wikimedia.org/r/908610

Umherirrender claimed this task.Apr 13 2023, 8:47 PM
gerritbot added a comment.Apr 14 2023, 12:31 PM

Change 908610 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] build: Enable PhanPluginNeverReturnMethod and make pass

https://gerrit.wikimedia.org/r/908610

gerritbot added a comment.Apr 14 2023, 7:17 PM

Change 908918 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Wikibase@master] build: Enable PhanPluginSimplifyExpressionBool and make pass

https://gerrit.wikimedia.org/r/908918

gerritbot added a comment.Apr 14 2023, 9:57 PM

Change 908583 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Wikibase@master] phan: Disable null_casts_as_any_type setting

https://gerrit.wikimedia.org/r/908583

gerritbot added a comment.Apr 17 2023, 3:34 PM

Change 908918 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] build: Enable PhanPluginSimplifyExpressionBool and make pass

https://gerrit.wikimedia.org/r/908918

gerritbot added a comment.Apr 17 2023, 4:45 PM

Change 908591 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] build: Enable PhanTypeMismatchReturn and make pass

https://gerrit.wikimedia.org/r/908591

gerritbot added a comment.Apr 18 2023, 9:58 AM

Change 908583 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] phan: Disable null_casts_as_any_type setting

https://gerrit.wikimedia.org/r/908583

Umherirrender closed this task as Resolved.Apr 18 2023, 4:29 PM
ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.9; 2023-05-15); removed MW-1.41-notes (1.41.0-wmf.5; 2023-04-17).May 15 2023, 2:47 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL