Page MenuHomePhabricator
Create Task
Maniphest T243621

Create query string parameter to enable/disable DiscussionTools on target wikis
Closed, ResolvedPublic
Actions

Description

In an effort to evaluate the reliability of the comment parser (T232780), which many DiscussionTools features depend (e.g. T233446), we would like to be able to test the parser on live talk pages prior to DiscussionTools being added as a Beta Feature.

Approach

During our 23-Jan standup, we decided the most straightforward way of accomplishing the above would be to create a new query string parameter.

Requirements

  • We need to be able to test DiscussionTools on specific talk pages, on specific wikis

Done

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Add config option and query parameter to control loadingmediawiki/extensions/DiscussionToolswmf/1.35.0-wmf.18+15 -3
Add config option and query parameter to control loadingmediawiki/extensions/DiscussionToolsmaster+15 -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

ppelberg created this task.Jan 24 2020, 6:54 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 24 2020, 6:54 PM
ppelberg renamed this task from Create query string parameter to enable DiscussionTools on target wikis to Create query string parameter to enable/disable DiscussionTools on target wikis.Jan 24 2020, 6:54 PM
ppelberg moved this task from Incoming to Ready for Development on the VisualEditor (Current work) board.
ppelberg updated the task description. (Show Details)
ppelberg updated the task description. (Show Details)Jan 24 2020, 6:56 PM

REMOVING "We need to be able to be able to disable/enable the query string parameter at any point" as a requirement; if/when we want to disable the parameter, we can write a patch to revert this one.

ppelberg mentioned this in T235923: Replies v1.0: release replying to specific comments.Jan 24 2020, 6:58 PM
matmarex claimed this task.Feb 4 2020, 8:43 PM
gerritbot added a comment.Feb 4 2020, 9:07 PM

Change 570142 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/DiscussionTools@master] Add config option and query parameter to control loading

https://gerrit.wikimedia.org/r/570142

gerritbot added a project: Patch-For-Review.Feb 4 2020, 9:07 PM
matmarex moved this task from Ready for Development to Code review on the VisualEditor (Current work) board.Feb 4 2020, 9:10 PM

With that patch, you can add ?dtenable=1 to the page URL to load DiscussionsTools on any page (assuming it's installed on the wiki). I'm also adding a config option $wgDiscussionToolsEnable which can be set to false, so that we can install DiscussionsTools on target wikis without actually enabling it on all talk pages there immediately.

JTannerWMF moved this task from Backlog to OWC2020 Replying 1.0 on the OWC2020 board.Feb 4 2020, 11:36 PM
JTannerWMF edited projects, added OWC2020 (OWC2020 Replying 1.0); removed OWC2020.
JTannerWMF edited projects, added Editing-team (Q3 2019-2020 Kanban Board); removed Editing-team, VisualEditor (Current work).Feb 5 2020, 12:01 AM
JTannerWMF moved this task from Needs Discussion / Investigation to Code Review on the Editing-team (Q3 2019-2020 Kanban Board) board.
JTannerWMF moved this task from Needs Prioritization to Required before Release on the OWC2020 (OWC2020 Replying 1.0) board.Feb 5 2020, 12:28 AM
gerritbot added a comment.Feb 5 2020, 12:52 AM

Change 570142 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] Add config option and query parameter to control loading

https://gerrit.wikimedia.org/r/570142

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.19; 2020-02-11).Feb 5 2020, 1:00 AM
Maintenance_bot removed a project: Patch-For-Review.Feb 5 2020, 1:10 AM
ppelberg mentioned this in T240607: Finalize Replying deployment strategy.Feb 5 2020, 1:23 AM
ppelberg mentioned this in T244432: Evaluate reliability of #DiscussionTools on target wikis.Feb 6 2020, 12:44 AM
ppelberg mentioned this in T244433: Evaluate reliability of #DiscussionTools on target wikis.
• Whatamidoing-WMF subscribed.Feb 7 2020, 9:07 PM
matmarex moved this task from Code Review to Ready for Sign Off on the Editing-team (Q3 2019-2020 Kanban Board) board.Feb 11 2020, 1:18 AM
matmarex added a project: Skipped QA.

(We don't currently have any public wiki with this configuration, but I tested it locally.)

ppelberg added a comment.Feb 11 2020, 1:31 AM
In T243621#5870871, @matmarex wrote:

(We don't currently have any public wiki with this configuration, but I tested it locally.)

Understood. Thank you, Bartosz. We'll QA this in production once we deploy Replying v1.0 to our target wikis.

ppelberg closed this task as Resolved.Feb 11 2020, 1:32 AM
ppelberg mentioned this in T244870: Deploy v1.0 via query string parameter to target wikis .Feb 11 2020, 3:37 PM
matmarex added a parent task: T244870: Deploy v1.0 via query string parameter to target wikis .Feb 11 2020, 4:25 PM
gerritbot added a comment.Feb 18 2020, 2:03 PM

Change 572882 had a related patch set uploaded (by Ladsgroup; owner: Bartosz Dziewoński):
[mediawiki/extensions/DiscussionTools@wmf/1.35.0-wmf.18] Add config option and query parameter to control loading

https://gerrit.wikimedia.org/r/572882

gerritbot added a project: Patch-For-Review.Feb 18 2020, 2:03 PM
gerritbot added a comment.Feb 18 2020, 2:08 PM

Change 572882 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@wmf/1.35.0-wmf.18] Add config option and query parameter to control loading

https://gerrit.wikimedia.org/r/572882

Maintenance_bot removed a project: Patch-For-Review.Feb 18 2020, 2:10 PM
ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.18; 2020-02-04); removed MW-1.35-notes (1.35.0-wmf.19; 2020-02-11).Feb 18 2020, 3:01 PM
ppelberg mentioned this in T251963: Test `visual` mode through query string.May 6 2020, 12:12 AM
ppelberg mentioned this in T284491: Make topic subscriptions available via URL parameter.Jun 7 2021, 7:46 PM
ppelberg mentioned this in T301144: Make Usability Improvements Available via URL Parameter.Feb 7 2022, 4:07 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits