Page MenuHomePhabricator

$wgUseExternalEditor prevents reuploading
Closed, ResolvedPublic

Description

Author: bugzilla

Description:
If the Setting $wgUseExternalEditor = false is ion effect, no link to reupload a picture or file is present.

Cause:
In ImagePage.php l.606:
if( $wgUseExternalEditor && $this->img->exists() ) {
$this->uploadLinksBox();
}

Fix:
if( $this->img->exists() ) {
$this->uploadLinksBox();
}

AND surround l.573-584 with an if:
if( $wgUseExternalEditor ) {
$elink = $sk->link(

			$this->mTitle,
			wfMsgHtml( 'edit-externally' ),
			array(),
			array(
				'action' => 'edit',
				'externaledit' => 'true',
				'mode' => 'file'
			),
			array( 'known', 'noclasses' )
		);
		$wgOut->addHTML( '<li id="mw-imagepage-edit-external">' . $elink . ' <small>' . wfMsgExt( 'edit-externally-help', array( 'parseinline' ) ) . "</small></li>\n" );

}


Version: 1.16.x
Severity: minor

Details

Reference
bz22364

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:49 PM
bzimport set Reference to bz22364.
bzimport added a subscriber: Unknown Object (MLST).
IAlex added a comment.Feb 5 2010, 2:07 PM

Fixed in r62023.

Gilles moved this task from Untriaged to Done on the Multimedia board.Dec 4 2014, 10:48 AM