Page MenuHomePhabricator

$wgUseExternalEditor prevents reuploading
Closed, ResolvedPublic

Description

Author: bugzilla

Description:
If the Setting $wgUseExternalEditor = false is ion effect, no link to reupload a picture or file is present.

Cause:
In ImagePage.php l.606:

if( $wgUseExternalEditor && $this->img->exists() ) {
 $this->uploadLinksBox();
}

Fix:

if( $this->img->exists() ) {
 $this->uploadLinksBox();
}

AND surround l.573-584 with an if:

if( $wgUseExternalEditor  ) {
 $elink = $sk->link(
			$this->mTitle,
			wfMsgHtml( 'edit-externally' ),
			array(),
			array(
				'action' => 'edit',
				'externaledit' => 'true',
				'mode' => 'file'
			),
			array( 'known', 'noclasses' )
		);
		$wgOut->addHTML( '<li id="mw-imagepage-edit-external">' . $elink . ' <small>' . wfMsgExt( 'edit-externally-help', array( 'parseinline' ) ) . "</small></li>\n" );
}

Version: 1.16.x

Details

Reference
bz22364

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:49 PM
bzimport set Reference to bz22364.
bzimport added a subscriber: Unknown Object (MLST).

Change 780684 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/Translate@master] DNM: Add TranslationAid to fetch edit summaries

https://gerrit.wikimedia.org/r/780684

Tacsipacsi updated the task description. (Show Details)
Tacsipacsi edited subscribers, added: Tacsipacsi; removed: wikibugs-l-list.