Page MenuHomePhabricator
Create Task
Maniphest T243652

Calls to LogPage::addEntry should pass a user
Closed, ResolvedPublic
Actions

Assigned To
DannyS712
Authored By
DannyS712
Jan 25 2020, 1:19 AM
Tags
Subscribers
Aklapper
ashley
DannyS712
Hexmode
MarkAHershberger
Umherirrender

Description

Currently accepts a user and defaults to $wgUser
Callers should provide this user

While all uses should be replaced, for repos not deployed by WMF / not hosted on gerrit / that cannot be updated by WMF developers this isn't a priority, and not prevent deprecation and removal

Details

Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

DannyS712 created this task.Jan 25 2020, 1:19 AM
Restricted Application added a project: User-DannyS712. · View Herald TranscriptJan 25 2020, 1:19 AM
gerritbot added a comment.Jan 25 2020, 1:20 AM

Change 567174 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/CentralAuth@master] Pass a user to LogPage::addEntry

https://gerrit.wikimedia.org/r/567174

gerritbot added a project: Patch-For-Review.Jan 25 2020, 1:21 AM
DannyS712 updated the task description. (Show Details)Jan 25 2020, 1:58 AM
gerritbot added a comment.Jan 25 2020, 1:59 AM

Change 567177 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/SocialProfile@master] Pass a user to LogPage::addEntry

https://gerrit.wikimedia.org/r/567177

gerritbot added a comment.Jan 25 2020, 2:02 AM

Change 567178 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/GlobalBlocking@master] Pass a user to LogPage::addEntry

https://gerrit.wikimedia.org/r/567178

gerritbot added a comment.Jan 25 2020, 2:04 AM

Change 567179 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/ApprovedRevs@master] Pass a user to LogPage::addEntry

https://gerrit.wikimedia.org/r/567179

gerritbot added a comment.Jan 25 2020, 2:11 AM

Change 567180 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/AutoProxyBlock@master] Pass a user to LogPage::addEntry

https://gerrit.wikimedia.org/r/567180

gerritbot added a comment.Jan 25 2020, 2:12 AM

Change 567181 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/BlockAndNuke@master] Pass a user to LogPage::addEntry

https://gerrit.wikimedia.org/r/567181

gerritbot added a comment.Jan 25 2020, 2:14 AM

Change 567182 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Cargo@master] Pass a user to LogPage::addEntry

https://gerrit.wikimedia.org/r/567182

gerritbot added a comment.Jan 25 2020, 2:23 AM

Change 567184 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/CloseWikis@master] Pass a user to LogPage::addEntry

https://gerrit.wikimedia.org/r/567184

gerritbot added a comment.Jan 25 2020, 2:27 AM

Change 567186 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Farmer@master] Pass a user to LogPage::addEntry

https://gerrit.wikimedia.org/r/567186

gerritbot added a comment.Jan 25 2020, 2:29 AM

Change 567187 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Interwiki@master] Pass a user to LogPage::addEntry

https://gerrit.wikimedia.org/r/567187

gerritbot added a comment.Jan 25 2020, 2:31 AM

Change 567188 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Poll@master] Pass a user to LogPage::addEntry

https://gerrit.wikimedia.org/r/567188

gerritbot added a comment.Jan 25 2020, 2:31 AM

Change 567188 abandoned by DannyS712:
Pass a user to LogPage::addEntry

Reason:
Woops, already provided

https://gerrit.wikimedia.org/r/567188

DannyS712 added projects: MediaWiki-extensions-CentralAuth, SocialProfile, GlobalBlocking, MediaWiki-extensions-Approved-Revs, MediaWiki-extensions-AutoProxyBlock, MediaWiki-extensions-BlockAndNuke, MediaWiki-extensions-Cargo, MediaWiki-extensions-Other, MediaWiki-extensions-Interwiki.Jan 25 2020, 2:36 AM
DannyS712 updated the task description. (Show Details)
Restricted Application added a project: Social-Tools. · View Herald TranscriptJan 25 2020, 2:36 AM
DannyS712 moved this task from Unsorted to In progress on the User-DannyS712 board.Jan 25 2020, 2:39 AM
DannyS712 updated the task description. (Show Details)EditedJan 25 2020, 8:47 AM
DannyS712 added subscribers: Hexmode, MarkAHershberger.

@Hexmode @MarkAHershberger would you mind looking at https://github.com/hexmode/mediawiki-UserSnoop/pull/3 and https://github.com/MWStake/mediawiki-extensions-UserLoginLog/pull/5 please?

DannyS712 updated the task description. (Show Details)Jan 25 2020, 8:50 AM
gerritbot added a comment.Jan 25 2020, 10:12 AM

Change 567200 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/RevisionCommentSupplement@master] Pass a user to LogPage::addEntry

https://gerrit.wikimedia.org/r/567200

gerritbot added a comment.Jan 25 2020, 10:14 AM

Change 567201 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/SpecialNamespaces@master] Pass a user to LogPage::addEntry

https://gerrit.wikimedia.org/r/567201

gerritbot added a comment.Jan 25 2020, 10:16 AM

Change 567202 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Sudo@master] Pass a user to LogPage::addEntry

https://gerrit.wikimedia.org/r/567202

DannyS712 updated the task description. (Show Details)Jan 25 2020, 10:23 AM
gerritbot added a comment.Jan 25 2020, 1:50 PM

Change 567202 merged by jenkins-bot:
[mediawiki/extensions/Sudo@master] Pass a user to LogPage::addEntry

https://gerrit.wikimedia.org/r/567202

gerritbot added a comment.Jan 25 2020, 2:00 PM

Change 567187 merged by jenkins-bot:
[mediawiki/extensions/Interwiki@master] Pass a user to LogPage::addEntry

https://gerrit.wikimedia.org/r/567187

gerritbot added a comment.Jan 25 2020, 2:00 PM

Change 567201 merged by jenkins-bot:
[mediawiki/extensions/SpecialNamespaces@master] Pass a user to LogPage::addEntry

https://gerrit.wikimedia.org/r/567201

DannyS712 updated the task description. (Show Details)Jan 25 2020, 6:12 PM
gerritbot added a comment.Jan 27 2020, 2:59 AM

Change 567177 merged by Jack Phoenix:
[mediawiki/extensions/SocialProfile@master] Pass a user to LogPage::addEntry

https://gerrit.wikimedia.org/r/567177

DannyS712 mentioned this in rESPRb512331bdcf4: Pass a user to LogPage::addEntry.Jan 27 2020, 3:45 AM
gerritbot added a comment.Jan 27 2020, 5:12 AM

Change 567179 merged by jenkins-bot:
[mediawiki/extensions/ApprovedRevs@master] Pass a user to LogPage::addEntry

https://gerrit.wikimedia.org/r/567179

DannyS712 updated the task description. (Show Details)Jan 27 2020, 5:15 AM
MarkAHershberger added a comment.Jan 28 2020, 4:56 PM

done

DannyS712 updated the task description. (Show Details)Jan 28 2020, 4:59 PM
Umherirrender added a subscriber: Umherirrender.Jan 28 2020, 9:43 PM

I just want noted that LogPage::addEntry is an old way to provide log entries on Special:Log.
The new way is direct use of LogFormatter class.
In my opinion there must be no complex actions to avoid global state in that class.
It would be more future proofed (but sometimes more complex) to migrate the extension to the new logging
But when the caller already have a context, than it is okay to avoid the fallback to $wgUser. That are simpel patch sets.

https://www.mediawiki.org/wiki/Manual:Logging_to_Special:Log

DannyS712 added a comment.Jan 28 2020, 9:46 PM

Noted. Perhaps it should officially be deprecated? Its currently not even soft deprecated.

ashley added a subscriber: ashley.Jan 29 2020, 9:18 AM
In T243652#5837176, @DannyS712 wrote:

Noted. Perhaps it should officially be deprecated? Its currently not even soft deprecated.

That would certainly make sense. I do want to note that for things like SocialProfile, the reason why it's still using the old class instead of the newer class is that I'm not sure how to properly migrate old log entries over. Migrating the code to use the newer classes would also help improve the i18n as well as overall aesthetic appearance of the relevant log entries (see, for example, the user profile edit log on Brickipedia to see how the entries currently display).

Umherirrender added a comment.Jan 29 2020, 6:16 PM
In T243652#5837762, @ashley wrote:
In T243652#5837176, @DannyS712 wrote:

Noted. Perhaps it should officially be deprecated? Its currently not even soft deprecated.

That would certainly make sense. I do want to note that for things like SocialProfile, the reason why it's still using the old class instead of the newer class is that I'm not sure how to properly migrate old log entries over. Migrating the code to use the newer classes would also help improve the i18n as well as overall aesthetic appearance of the relevant log entries (see, for example, the user profile edit log on Brickipedia to see how the entries currently display).

There is no need to migrate old log entries. The old log entries are detected as legacy and displayed the old way.
New log entries are stored (in the same table) after the new code is there and used. But the new logformatter must be always backward compatibility when adding new params to the log type or removing parameters. It must show the older log entries (but not the legacy one) like it was on insert. Look at the block formatter or protect formatter how complicated that could be. There are also tests for both classes to test against older parameter combination.

gerritbot added a comment.Jan 31 2020, 11:22 AM

Change 567186 merged by jenkins-bot:
[mediawiki/extensions/Farmer@master] Pass a user to LogPage::addEntry

https://gerrit.wikimedia.org/r/567186

gerritbot added a comment.Jan 31 2020, 11:23 AM

Change 567184 merged by jenkins-bot:
[mediawiki/extensions/CloseWikis@master] Pass a user to LogPage::addEntry

https://gerrit.wikimedia.org/r/567184

gerritbot added a comment.Jan 31 2020, 11:25 AM

Change 567180 merged by jenkins-bot:
[mediawiki/extensions/AutoProxyBlock@master] Pass a user to LogPage::addEntry

https://gerrit.wikimedia.org/r/567180

gerritbot added a comment.Jan 31 2020, 11:27 AM

Change 567178 merged by jenkins-bot:
[mediawiki/extensions/GlobalBlocking@master] Pass a user to LogPage::addEntry

https://gerrit.wikimedia.org/r/567178

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.18; 2020-02-04).Jan 31 2020, 12:00 PM
DannyS712 updated the task description. (Show Details)Jan 31 2020, 5:19 PM
gerritbot added a comment.Feb 4 2020, 8:19 PM

Change 567181 merged by jenkins-bot:
[mediawiki/extensions/BlockAndNuke@master] Pass a user to LogPage::addEntry

https://gerrit.wikimedia.org/r/567181

DannyS712 updated the task description. (Show Details)Feb 4 2020, 9:14 PM
gerritbot added a comment.Feb 4 2020, 9:42 PM

Change 570145 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/LiquidThreads@master] Pass a user to LogPage::addEntry

https://gerrit.wikimedia.org/r/570145

DannyS712 updated the task description. (Show Details)Feb 4 2020, 9:48 PM
gerritbot added a comment.Feb 4 2020, 9:57 PM

Change 570149 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/ProtectSite@master] Pass a user to LogPage::addEntry

https://gerrit.wikimedia.org/r/570149

DannyS712 updated the task description. (Show Details)Feb 4 2020, 9:59 PM
DannyS712 added a project: MediaWiki-extensions-LiquidThreads.
DannyS712 moved this task from In progress to Awaiting review and deployment on the User-DannyS712 board.
gerritbot added a comment.Feb 5 2020, 1:31 AM

Change 570149 merged by jenkins-bot:
[mediawiki/extensions/ProtectSite@master] Pass a user to LogPage::addEntry

https://gerrit.wikimedia.org/r/570149

DannyS712 updated the task description. (Show Details)Feb 5 2020, 6:08 AM
DannyS712 moved this task from Backlog to Doing on the MediaWiki-extensions-Cargo board.Feb 5 2020, 6:20 AM
DannyS712 updated the task description. (Show Details)
gerritbot added a comment.Feb 5 2020, 2:10 PM

Change 567182 merged by jenkins-bot:
[mediawiki/extensions/Cargo@master] Pass a user to LogPage::addEntry

https://gerrit.wikimedia.org/r/567182

DannyS712 updated the task description. (Show Details)Feb 5 2020, 4:11 PM
gerritbot added a comment.Feb 13 2020, 8:38 PM

Change 567200 merged by jenkins-bot:
[mediawiki/extensions/RevisionCommentSupplement@master] Pass a user to LogPage::addEntry

https://gerrit.wikimedia.org/r/567200

gerritbot added a comment.Feb 14 2020, 3:26 AM

Change 570145 merged by jenkins-bot:
[mediawiki/extensions/LiquidThreads@master] Pass a user to LogPage::addEntry

https://gerrit.wikimedia.org/r/570145

DannyS712 updated the task description. (Show Details)Feb 14 2020, 3:29 AM
ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.20; 2020-02-18); removed MW-1.35-notes (1.35.0-wmf.18; 2020-02-04).Feb 14 2020, 4:00 AM
gerritbot added a comment.Feb 19 2020, 5:02 AM

Change 567174 merged by jenkins-bot:
[mediawiki/extensions/CentralAuth@master] Pass a user to LogPage::addEntry

https://gerrit.wikimedia.org/r/567174

gerritbot added a comment.Feb 19 2020, 5:24 AM

Change 563759 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Deprecate falling back to $wgUser in some functions

https://gerrit.wikimedia.org/r/563759

DannyS712 updated the task description. (Show Details)Feb 19 2020, 5:25 AM
ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.21; 2020-02-25); removed MW-1.35-notes (1.35.0-wmf.20; 2020-02-18).Feb 19 2020, 6:00 AM
gerritbot added a comment.Feb 20 2020, 2:04 AM

Change 563759 merged by jenkins-bot:
[mediawiki/core@master] Deprecate falling back to $wgUser in some functions

https://gerrit.wikimedia.org/r/563759

DannyS712 closed this task as Resolved.Feb 20 2020, 2:04 AM
DannyS712 removed a project: Patch-For-Review.

Not passing a user is deprecated

DannyS712 mentioned this in T245701: Remove support for calling LogPage::addEntry without passing a user object.Feb 20 2020, 2:09 AM
DannyS712 mentioned this in T243708: Mediawiki core needs uses of global $wgUser removed.Feb 22 2020, 1:18 AM
DannyS712 added a project: MediaWiki-extensions-CloseWikis.Feb 22 2020, 4:54 AM
DannyS712 moved this task from Awaiting review and deployment to Resolved (deprecation) on the User-DannyS712 board.Feb 23 2020, 10:23 AM
DannyS712 added a project: MediaWiki-extensions-RevisionCommentSupplement.Mar 8 2020, 6:43 PM
DannyS712 added a project: MediaWiki-extensions-Farmer.Mar 15 2020, 3:58 AM
DannyS712 added a project: MediaWiki-extensions-Sudo.Mar 15 2020, 4:02 AM
DannyS712 added a project: MediaWiki-extensions-StalkerLog.Mar 15 2020, 4:29 AM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL