Page MenuHomePhabricator
Create Task
Maniphest T243661

Missing "ext.geshi.visualEditor" dependency in VEForAll creates JS Error when SyntaxHighlight_GeSHi is enabled
Closed, ResolvedPublic
Actions

Description

With enabled SyntaxHighlight_GeSHi, VEForAll throws

TypeError: Cannot read property 'on' of undefined

Javascript error.

This can be fixed by adding

"ext.geshi.visualEditor"

to VEForAll's extension.json ext.veforall.core dependencies. It would be good, if the missing dependency could be added dynamically as soon as SyntaxHighlight_GeSHi is available.

Event Timeline

planetenxin created this task.Jan 25 2020, 11:01 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 25 2020, 11:01 AM
Aklapper renamed this task from JS Error with enabled SyntaxHighlight_GeSHi to Missing "ext.geshi.visualEditor" dependency in VEForAll creates JS Error when SyntaxHighlight_GeSHi is enabled.Jan 28 2020, 1:13 PM
Yaron_Koren closed this task as Resolved.Aug 1 2023, 1:55 PM
Yaron_Koren claimed this task.
Yaron_Koren subscribed.

I don't know how this got fixed, since I don't think that was dependency was added, but I just tried it and the combination of SyntaxHighlight, VEForAll and Page Forms seems to work fine for me - and no JavaScript errors appear. I assume this can be closed.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL