Page MenuHomePhabricator
Create Task
Maniphest T243729

Check Wikibase services for expensive setup patterns (db & api calls etc) & fix / remove
Closed, ResolvedPublic
Actions

Description

T243725: HtmlPageLinkRendererBeginHookHandler creates a LanguageFallbackChain when it may not be needed highlights one particular issue.
Along with this being fixed other services should also be checked for similar patterns and fixed where needed.
Documentation should be updated to highlight this pattern to be avoided.

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/WikibaseREL1_36+11 -0repo: Mock getLazyConnectionRef
mediawiki/extensions/Wikibasewmf/1.37.0-wmf.4+11 -13Backport CI fixes
mediawiki/extensions/Wikibasemaster+11 -13Backport CI fixes
mediawiki/extensions/Wikibasewmf/1.37.0-wmf.5+11 -0repo: Mock getLazyConnectionRef
mediawiki/extensions/Wikibasewmf/1.37.0-wmf.4+11 -0repo: Mock getLazyConnectionRef
mediawiki/extensions/Wikibasemaster+11 -0repo: Mock getLazyConnectionRef
mediawiki/extensions/Wikibasemaster+49 -0Make sure WikibaseServices services getters don't access the DB
mediawiki/extensions/Wikibasemaster+364 -0Test that factory methods don't access the DB/ do http requests
mediawiki/extensions/Wikibasemaster+133 -1Assert service getters never access the DB/ do http requests
Customize query in gerrit

Related Objects
Search...

Event Timeline

Addshore created this task.Jan 26 2020, 9:50 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 26 2020, 9:50 PM
Addshore triaged this task as High priority.Jan 26 2020, 9:50 PM
Addshore moved this task from Incoming to Ready to pick up on the Wikidata-Campsite board.
Bawolff added a subscriber: Bawolff.Jan 27 2020, 7:05 AM
WMDE-leszek added a subscriber: WMDE-leszek.Jan 27 2020, 9:03 AM
Michael added a subscriber: Michael.Jan 27 2020, 9:57 AM
Addshore moved this task from Ready to pick up to Wikidata-Campsite-Iteration-∞ (On Hold) on the Wikidata-Campsite board.Jan 27 2020, 10:32 AM
Addshore edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)); removed Wikidata-Campsite.
Addshore added a comment.Jan 27 2020, 10:51 AM

Relates to T243713: Time-out error; Babel/WikibaseRepo being somehow uncached, overloading the API, and causing general outage

Maintenance_bot moved this task from incoming to in progress on the Wikidata board.Jan 27 2020, 11:15 AM
• Ladsgroup added a subscriber: • Ladsgroup.Jan 28 2020, 9:18 PM

I have some ideas about this but xhgui is down :( https://performance.wikimedia.org/xhgui/ I will try later.

• Ladsgroup added a comment.Jan 28 2020, 10:28 PM

I for now leave these here for tomorrow:

• Ladsgroup added a parent task: T243915: Performance audit of Wikibase/Wikidata, Jan 2020.Jan 29 2020, 4:19 PM
Addshore renamed this task from Check Wikibase services for expensive setup patterns & fix to Check Wikibase services for expensive setup patterns (db & api calls etc) & fix / remove.Jan 30 2020, 9:16 AM
Addshore added a comment.Feb 7 2020, 12:33 PM

So this taks still needs to look for the same pattern of service construction where one of the things injected into the service ends up doing dB calls or API calls (what was happening with the language fallback chain issue).
Less of a profiling thing and more of a looking by eye thing.
Might be able to do something clever actually where a test replaces the db layer and http call later and calls all of the wikibase repo getters, making sure no http or SQL calls are done.

hoo claimed this task.Feb 10 2020, 2:38 PM
hoo moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
gerritbot added a comment.Feb 10 2020, 4:42 PM

Change 571318 had a related patch set uploaded (by Hoo man; owner: Hoo man):
[mediawiki/extensions/Wikibase@master] Assert service getters never access the DB/ do http requests

https://gerrit.wikimedia.org/r/571318

gerritbot added a project: Patch-For-Review.Feb 10 2020, 4:42 PM
gerritbot added a comment.Feb 10 2020, 6:45 PM

Change 571318 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Assert service getters never access the DB/ do http requests

https://gerrit.wikimedia.org/r/571318

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.19; 2020-02-11).Feb 10 2020, 7:01 PM
gerritbot added a comment.Feb 11 2020, 12:00 PM

Change 571474 had a related patch set uploaded (by Hoo man; owner: Hoo man):
[mediawiki/extensions/Wikibase@master] Test that factory methods don't access the DB/ do http requests

https://gerrit.wikimedia.org/r/571474

hoo moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Feb 11 2020, 12:00 PM
gerritbot added a comment.Feb 11 2020, 1:28 PM

Change 571474 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Test that factory methods don't access the DB/ do http requests

https://gerrit.wikimedia.org/r/571474

hoo moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Feb 11 2020, 1:33 PM

We now have fairly conclusive test coverage of this (covers all from-global-state-factory methods I could find), so I think we can consider this done.

Maintenance_bot removed a project: Patch-For-Review.Feb 11 2020, 2:10 PM
Addshore moved this task from Test (Verification) to To Do (prioritised from top to bottom) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Feb 17 2020, 8:17 AM

Very nice tests for this case :)
We probably also need to do this for the services held withing WikibaseRepo->getWikibaseServices which holds currently another 10 services.

hoo moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Feb 17 2020, 11:58 AM
gerritbot added a comment.Feb 17 2020, 1:08 PM

Change 572664 had a related patch set uploaded (by Hoo man; owner: Hoo man):
[mediawiki/extensions/Wikibase@master] Make sure WikibaseServices services getters don't access the DB

https://gerrit.wikimedia.org/r/572664

gerritbot added a project: Patch-For-Review.Feb 17 2020, 1:08 PM
hoo moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Feb 17 2020, 1:09 PM
• Ladsgroup moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Feb 17 2020, 4:28 PM
• Ladsgroup moved this task from Test (Verification) to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Addshore moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Feb 19 2020, 7:02 AM
gerritbot added a comment.Feb 19 2020, 12:00 PM

Change 572664 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Make sure WikibaseServices services getters don't access the DB

https://gerrit.wikimedia.org/r/572664

Maintenance_bot removed a project: Patch-For-Review.Feb 19 2020, 12:10 PM
ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.21; 2020-02-25); removed MW-1.35-notes (1.35.0-wmf.19; 2020-02-11).Feb 19 2020, 1:00 PM
Addshore closed this task as Resolved.Mar 4 2020, 4:11 PM
Lucas_Werkmeister_WMDE mentioned this in T276090: Assert in service wiring unit tests that no DB/HTTP calls are made.Mar 1 2021, 1:28 PM
Tgr mentioned this in T282731: Wikibase\...: TypeError: Argument 1 passed to GrowthExperiments\...\LinkRecommendationStore::__construct() must implement interface ...\IDatabase, null given.May 12 2021, 7:14 PM
Maintenance_bot moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.May 12 2021, 7:15 PM
gerritbot added a comment.May 12 2021, 7:24 PM

Change 690032 had a related patch set uploaded (by Gergő Tisza; author: Kosta Harlan):

[mediawiki/extensions/Wikibase@master] repo: Mock getLazyConnectionRef

https://gerrit.wikimedia.org/r/690032

gerritbot added a project: Patch-For-Review.May 12 2021, 7:24 PM
gerritbot added a comment.May 12 2021, 7:49 PM

Change 690032 merged by Gergő Tisza:

[mediawiki/extensions/Wikibase@master] repo: Mock getLazyConnectionRef

https://gerrit.wikimedia.org/r/690032

gerritbot added a comment.May 12 2021, 7:55 PM

Change 689899 had a related patch set uploaded (by Jforrester; author: Kosta Harlan):

[mediawiki/extensions/Wikibase@wmf/1.37.0-wmf.4] repo: Mock getLazyConnectionRef

https://gerrit.wikimedia.org/r/689899

gerritbot added a comment.May 12 2021, 7:55 PM

Change 689900 had a related patch set uploaded (by Jforrester; author: Kosta Harlan):

[mediawiki/extensions/Wikibase@wmf/1.37.0-wmf.5] repo: Mock getLazyConnectionRef

https://gerrit.wikimedia.org/r/689900

gerritbot added a comment.May 12 2021, 9:39 PM

Change 689899 abandoned by Gergő Tisza:

[mediawiki/extensions/Wikibase@wmf/1.37.0-wmf.4] repo: Mock getLazyConnectionRef

Reason:

needs to be squashed

https://gerrit.wikimedia.org/r/689899

gerritbot added a comment.May 12 2021, 9:45 PM

Change 690045 had a related patch set uploaded (by Gergő Tisza; author: Kosta Harlan):

[mediawiki/extensions/Wikibase@master] Backport CI fixes

https://gerrit.wikimedia.org/r/690045

gerritbot added a comment.May 12 2021, 10:41 PM

Change 689900 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@wmf/1.37.0-wmf.5] repo: Mock getLazyConnectionRef

https://gerrit.wikimedia.org/r/689900

gerritbot added a comment.May 12 2021, 11:39 PM

Change 690045 merged by Gergő Tisza:

[mediawiki/extensions/Wikibase@master] Backport CI fixes

https://gerrit.wikimedia.org/r/690045

gerritbot added a comment.May 12 2021, 11:52 PM

Change 690066 had a related patch set uploaded (by Gergő Tisza; author: Kosta Harlan):

[mediawiki/extensions/Wikibase@wmf/1.37.0-wmf.4] Backport CI fixes

https://gerrit.wikimedia.org/r/690066

gerritbot added a comment.May 12 2021, 11:57 PM

Change 690066 merged by Gergő Tisza:

[mediawiki/extensions/Wikibase@wmf/1.37.0-wmf.4] Backport CI fixes

https://gerrit.wikimedia.org/r/690066

gerritbot added a comment.Apr 9 2022, 3:52 PM

Change 778627 had a related patch set uploaded (by Umherirrender; author: Kosta Harlan):

[mediawiki/extensions/Wikibase@REL1_36] repo: Mock getLazyConnectionRef

https://gerrit.wikimedia.org/r/778627

gerritbot added a comment.Apr 9 2022, 4:31 PM

Change 778627 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@REL1_36] repo: Mock getLazyConnectionRef

https://gerrit.wikimedia.org/r/778627

Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL