Page MenuHomePhabricator

Add pure unit tests for class LinkHolderArray
Closed, ResolvedPublic3 Estimated Story Points

Description

Motivation:

class LinkHolderArray doesn't have pure unit tests.
It's partially covered by integration tests though.
https://doc.wikimedia.org/cover/mediawiki-core/includes/parser/LinkHolderArray.php.html

Expected result:

  • More tests should be added.
  • class LinkHolderArray should be covered by pure unit tests for 100%

Event Timeline

Change 588834 had a related patch set uploaded (by Art-Baltai; owner: Art-Baltai):
[mediawiki/core@master] Add pure unit tests for class LinkHolderArray

https://gerrit.wikimedia.org/r/588834

Helga_sf set the point value for this task to 3.Apr 16 2020, 9:46 AM

Change 588834 merged by jenkins-bot:
[mediawiki/core@master] New unit and integraton tests for class LinkHolderArray

https://gerrit.wikimedia.org/r/588834

Helga_sf added a subscriber: Art-Baltai.
Helga_sf removed a subscriber: Art-Baltai.
Peter.ovchyn triaged this task as Low priority.

I don't see how this has anything to do with Language Converter, plus I assume this has been fixed three years ago. If not, please reopen and clarify.