Add pure unit tests for class LinkHolderArray
Closed, ResolvedPublic3 Estimated Story Points
Actions

Assigned To

None

Authored By

	Peter.ovchyn
	Jan 27 2020, 10:15 AM

Description

Motivation:

class LinkHolderArray doesn't have pure unit tests.
It's partially covered by integration tests though.
https://doc.wikimedia.org/cover/mediawiki-core/includes/parser/LinkHolderArray.php.html

Expected result:

More tests should be added.
class LinkHolderArray should be covered by pure unit tests for 100%

Details

	Subject	Repo	Branch	Lines +/-
	New unit and integraton tests for class LinkHolderArray	mediawiki/core	master	+432 -0

Customize query in gerrit

Event Timeline

Peter.ovchyn created this task.Jan 27 2020, 10:15 AM

Restricted Application removed a project: Patch-For-Review. · View Herald TranscriptJan 27 2020, 10:15 AM

Peter.ovchyn removed a parent task: T226833: Introduce LanguageConverterFactory service.Jan 31 2020, 9:48 AM

daniel removed a project: Platform Engineering.Feb 5 2020, 7:28 PM

Peter.ovchyn removed Peter.ovchyn as the assignee of this task.Feb 12 2020, 10:04 AM

Helga_sf moved this task from Backlog to Estimated/Estimation on the Platform Team Workboards (S&F Workboard) board.Mar 31 2020, 5:17 PM

Art-Baltai claimed this task.Apr 15 2020, 4:45 AM

Art-Baltai moved this task from Estimated/Estimation to In Progress/Doing on the Platform Team Workboards (S&F Workboard) board.

Change 588834 had a related patch set uploaded (by Art-Baltai; owner: Art-Baltai):
[mediawiki/core@master] Add pure unit tests for class LinkHolderArray

https://gerrit.wikimedia.org/r/588834

gerritbot added a project: Patch-For-Review.Apr 15 2020, 5:30 AM

Helga_sf moved this task from In Progress/Doing to Current sprint Backlog on the Platform Team Workboards (S&F Workboard) board.Apr 16 2020, 9:40 AM

Helga_sf set the point value for this task to 3.Apr 16 2020, 9:46 AM

Helga_sf moved this task from Current sprint Backlog to In Progress/Doing on the Platform Team Workboards (S&F Workboard) board.Apr 16 2020, 10:26 AM

Art-Baltai moved this task from In Progress/Doing to In Progress/In Review on the Platform Team Workboards (S&F Workboard) board.Apr 17 2020, 1:29 AM

Change 588834 merged by jenkins-bot:
[mediawiki/core@master] New unit and integraton tests for class LinkHolderArray

https://gerrit.wikimedia.org/r/588834

DannyS712 removed a project: Patch-For-Review.Jun 10 2020, 10:42 AM

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.37; 2020-06-16).Jun 10 2020, 11:00 AM

Helga_sf reassigned this task from Art-Baltai to Peter.ovchyn.Jun 23 2020, 5:08 PM

Helga_sf added a subscriber: Art-Baltai.

Helga_sf removed a subscriber: Art-Baltai.

Peter.ovchyn moved this task from In Progress/In Review to Backlog on the Platform Team Workboards (S&F Workboard) board.Oct 21 2020, 12:31 PM

Peter.ovchyn removed Peter.ovchyn as the assignee of this task.Oct 21 2020, 12:34 PM

Peter.ovchyn triaged this task as Low priority.

Art.tsymbar assigned this task to Vlad.shapik.Oct 26 2020, 8:25 AM

Vlad.shapik removed Vlad.shapik as the assignee of this task.Dec 1 2021, 7:03 PM

Vlad.shapik subscribed.

Winston_Sung moved this task from Backlog to Core on the MediaWiki-Language-converter board.Mar 18 2023, 4:04 AM

I don't see how this has anything to do with Language Converter, plus I assume this has been fixed three years ago. If not, please reopen and clarify.

Add pure unit tests for class LinkHolderArrayClosed, ResolvedPublic3 Estimated Story PointsActions