| Lydia_Pintscher | |
| Jan 27 2020, 3:29 PM |
Problem:
We for now want to only support editing statements that have a property of data type string. However our current check is based on the value type instead. This means it is also possible to edit among others the data types URL, Commons media, tabular data, geo shape and musical notation. We need to check for the data type.
Acceptance criteria:
| Subject | Author | Repo | Branch | Lines +/- | |
|---|---|---|---|---|---|
| bridge: check for string data type | Lucas Werkmeister (WMDE) | mediawiki/extensions/Wikibase | master | +124 -13 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T228066 Step 1: Error States of Data-Bridge [Tracking] (impact: medium) | |||
| Resolved | Charlie_WMDE | T235753 Step 1: Bail-out path for unsupported datatypes (impact: high) | |||
| Resolved | • Tonina_Zhelyazkova_WMDE | T242843 Display UNSUPPORTED_ENTITY_DATA error in ErrorWrapper | |||
| Resolved | Lucas_Werkmeister_WMDE | T243773 Step 1: restrict editing to string data type - not just value type |
Change 568489 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] bridge: check for string data type
Change 568489 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: check for string data type
though it will look even better with T235753: Step 1: Bail-out path for unsupported datatypes (impact: high) ;)