Page MenuHomePhabricator

Replace unfetch with XMLHTTPRequest
Closed, ResolvedPublic

Description

unfetch was brought in to be able to support IE quickly since it doesn't have a native fetch implementation. However, it should be rewritten to use XMLHTTPRequest so it doesn't have any run-time dependencies. This will also make the bundle smaller.

Note that the new code should be written with callbacks and not promises so it doesn't need a polyfill in IE.

Event Timeline

SBisson moved this task from Backlog to Code Review on the Inuka-Team (Kanban) board.
SBisson added subscribers: eamedina, hueitan.

https://github.com/wikimedia/wikipedia-previews/pull/1

@hueitan @eamedina No rush to review this. Let's discuss this project together first ;)

Jpita subscribed.

I think this broke IE11, there's no popup now

hueitan moved this task from QA WAITING FOR FEEDBACK to Dev on the Inuka-Team (Kanban) board.

working on it, move back to dev

Note:
The original PR is merged, this will be fixed in another PR