Page MenuHomePhabricator
Create Task
Maniphest T243790

Upgrade nyc to latest version
Closed, ResolvedPublic
Actions

Description

Usage: https://libraryupgrader2.wmflabs.org/library/npm/nyc

npm audit reports issues, but that needs a new major version to fix.
That is not supported by libup

It is okay to upgrade to latest (15.0.0)?
Could be done using the libup / config file instead.

Details

SubjectRepoBranchLines +/-
build: Upgrade nyc from 13.0.1 to 15.0.0mediawiki/extensions/MobileFrontendmaster+887 -1 K
build: Upgrade nyc from 13.1.0 to 15.0.0mediawiki/extensions/Popupsmaster+912 -1 K
build: Upgrade nyc from 13.1.0 to 15.0.0mediawiki/extensions/GrowthExperimentsmaster+1 K -2 K
build: Upgrade nyc from 13.1.0 to 15.0.0mediawiki/extensions/WikibaseMediaInfomaster+7 K -7 K
Customize query in gerrit

Event Timeline

Umherirrender created this task.Jan 27 2020, 9:00 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptJan 27 2020, 9:00 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Legoktm added a comment.Jan 27 2020, 9:06 PM

Could be done using the libup / config file instead.

I don't know if it's safe to upgrade, but doing it via the libup/config repo is the best way to do so IMO.

Umherirrender updated the task description. (Show Details)Jan 27 2020, 9:21 PM
Jdlrobson added a project: Web-Team-Backlog (Kanbanana-2019-20-Q3).Jan 28 2020, 1:27 PM
Jdlrobson subscribed.Jan 30 2020, 4:47 AM

No issues with upgrading for MobileFrontend (actually I would appreciate!). I tried out npm run coverage command on MobileFrontend with this version of nyc and it works as before. The uncovered lines report is much more useful after the upgrade.

Jdlrobson edited projects, added Web-Team-Backlog (Tracking); removed Web-Team-Backlog (Kanbanana-2019-20-Q3).Jan 30 2020, 4:48 AM
gerritbot added a comment.Feb 3 2020, 10:43 PM

Change 569664 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/GrowthExperiments@master] build: Upgrade nyc from 13.1.0 to 15.0.0

https://gerrit.wikimedia.org/r/569664

gerritbot added a project: Patch-For-Review.Feb 3 2020, 10:43 PM
gerritbot added a comment.Feb 3 2020, 10:52 PM

Change 569668 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/WikibaseMediaInfo@master] build: Upgrade nyc from 13.1.0 to 15.0.0

https://gerrit.wikimedia.org/r/569668

Jdforrester-WMF removed a project: LibUp.Feb 3 2020, 11:01 PM
Jdforrester-WMF subscribed.

LibUp won't upgrade breaking change versions. Doing manually.

Jdforrester-WMF edited projects, added Navigation-Popups-Gadget; removed MediaWiki-extensions-General.Feb 3 2020, 11:01 PM
gerritbot added a comment.Feb 3 2020, 11:03 PM

Change 569670 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/MobileFrontend@master] build: Upgrade nyc from 13.0.1 to 15.0.0

https://gerrit.wikimedia.org/r/569670

gerritbot added a comment.Feb 3 2020, 11:13 PM

Change 569672 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/Popups@master] build: Upgrade nyc from 13.1.0 to 15.0.0

https://gerrit.wikimedia.org/r/569672

Legoktm added a comment.Feb 4 2020, 4:24 AM
In T243790#5846415, @Jdforrester-WMF wrote:

LibUp won't upgrade breaking change versions. Doing manually.

Just to clarify, libup can easily do patches like https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/+/569664 if the nyc bump is configured in the libup/config repo.

It will not do major bumps because of npm audit finding a security issue.

gerritbot added a comment.Feb 4 2020, 4:44 AM

Change 569668 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] build: Upgrade nyc from 13.1.0 to 15.0.0

https://gerrit.wikimedia.org/r/569668

gerritbot added a comment.Feb 4 2020, 4:44 AM

Change 569664 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] build: Upgrade nyc from 13.1.0 to 15.0.0

https://gerrit.wikimedia.org/r/569664

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.18; 2020-02-04).Feb 4 2020, 5:00 AM
gerritbot added a comment.Feb 4 2020, 8:04 AM

Change 569672 merged by jenkins-bot:
[mediawiki/extensions/Popups@master] build: Upgrade nyc from 13.1.0 to 15.0.0

https://gerrit.wikimedia.org/r/569672

gerritbot added a comment.Feb 4 2020, 9:40 AM

Change 569670 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] build: Upgrade nyc from 13.0.1 to 15.0.0

https://gerrit.wikimedia.org/r/569670

Maintenance_bot removed a project: Patch-For-Review.Feb 4 2020, 10:10 AM
Jdlrobson moved this task from Backlog to Team:Growth on the MobileFrontend board.Jul 24 2020, 2:32 AM
TheDJ edited projects, added Page-Previews; removed Navigation-Popups-Gadget.Apr 12 2021, 6:52 PM
MBinder_WMF added a project: Growth-Team-Filtering.Apr 15 2021, 6:51 PM
Jdlrobson edited projects, added Web-Team-Backlog (Needs Prioritization (Tech)); removed Web-Team-Backlog (Tracking).Sep 7 2021, 9:13 PM
Jdlrobson moved this task from Backlog to Future Unplanned on the Web-Team-Backlog (Needs Prioritization (Tech)) board.Sep 8 2021, 4:13 PM
Jdlrobson closed this task as Resolved.Sep 21 2021, 4:10 PM
Jdlrobson claimed this task.

this work looks complete to me. https://codesearch.wmcloud.org/extensions/?q=%22nyc%22%3A%20%221&i=nope&files=&excludeFiles=&repos=

Restricted Application added a project: Structured-Data-Backlog. · View Herald TranscriptSep 21 2021, 4:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL