Page MenuHomePhabricator
Create Task
Maniphest T243805

WebRequest::getLimitOffset should accept a user
Closed, ResolvedPublic
Actions

Description

Currently, WebRequest::getLimitOffset accepts an optional default limit, and an optional option name, as parameters.
There should be a user parameter accepted, and eventually, required, for accessing user preferences.
To clarify that the function gets the limit and offset for a specific user, I suggest:

  • Create WebRequest::getLimitOffsetForUser
    • Which requires a user to be passed to get the user preference for an option
  • Convert WebRequest::getLimitOffset to a wrapper that simple uses $wgUser
  • Replace uses of ::getLimitOffset with ::getLimitOffsetForUser, supplying a user, since whether its needed or not depends on unknown user input
  • Deprecate ::getLimitOffset

Deployed uses of getLimitOffset:
https://codesearch.wmflabs.org/deployed/?q=getLimitOffset%5C(&i=nope&files=&repos=

Details

SubjectRepoBranchLines +/-
Hard deprecate WebRequest::getLimitOffsetmediawiki/coremaster+3 -2
Replace WebRequest::getLimitOffset with ::getLimitOffsetForUsermediawiki/extensions/Wikibasemaster+2 -1
Replace WebRequest::getLimitOffset with ::getLimitOffsetForUsermediawiki/extensions/Flowmaster+6 -2
Replace WebRequest::getLimitOffset with ::getLimitOffsetForUsermediawiki/extensions/CentralNoticemaster+15 -3
Replace WebRequest::getLimitOffset with ::getLimitOffsetForUsermediawiki/coremaster+16 -6
Replace WebRequest::getLimitOffset with ::getLimitOffsetForUsermediawiki/extensions/ProofreadPagemaster+2 -1
Add WebRequest::getLimitOffsetForUser to replace ::getLimitOffsetmediawiki/coremaster+20 -4
Customize query in gerrit

Related Objects
Search...

Event Timeline

DannyS712 created this task.Jan 28 2020, 12:27 AM
Restricted Application added a project: User-DannyS712. · View Herald TranscriptJan 28 2020, 12:27 AM
gerritbot added a comment.Jan 28 2020, 12:29 AM

Change 567528 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Add WebRequest::getLimitOffsetForUser to replace ::getLimitOffset

https://gerrit.wikimedia.org/r/567528

gerritbot added a project: Patch-For-Review.Jan 28 2020, 12:29 AM
DannyS712 updated the task description. (Show Details)Jan 28 2020, 12:33 AM
DannyS712 moved this task from Unsorted to Awaiting review and deployment on the User-DannyS712 board.Jan 28 2020, 12:38 AM
DannyS712 updated the task description. (Show Details)Jan 28 2020, 12:40 AM
DannyS712 added a comment.Feb 6 2020, 7:37 PM

WMF deployed uses that will need to be updated:
https://codesearch.wmflabs.org/deployed/?q=getLimitOffset%5C(&i=nope&files=&repos=

gerritbot added a comment.Feb 19 2020, 12:33 AM

Change 567528 merged by jenkins-bot:
[mediawiki/core@master] Add WebRequest::getLimitOffsetForUser to replace ::getLimitOffset

https://gerrit.wikimedia.org/r/567528

DannyS712 added projects: MediaWiki-extensions-CentralNotice, StructuredDiscussions, ProofreadPage, MediaWiki-extensions-WikibaseRepository.Feb 19 2020, 12:39 AM
DannyS712 updated the task description. (Show Details)
Restricted Application added projects: Growth-Team, Wikidata. · View Herald TranscriptFeb 19 2020, 12:39 AM
gerritbot added a comment.Feb 19 2020, 12:39 AM

Change 573027 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/CentralNotice@master] Replace WebRequest::getLimitOffset with ::getLimitOffsetForUser

https://gerrit.wikimedia.org/r/573027

gerritbot added a comment.Feb 19 2020, 12:42 AM

Change 573029 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Flow@master] Replace WebRequest::getLimitOffset with ::getLimitOffsetForUser

https://gerrit.wikimedia.org/r/573029

gerritbot added a comment.Feb 19 2020, 12:44 AM

Change 573030 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/ProofreadPage@master] Replace WebRequest::getLimitOffset with ::getLimitOffsetForUser

https://gerrit.wikimedia.org/r/573030

gerritbot added a comment.Feb 19 2020, 12:45 AM

Change 573031 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Wikibase@master] Replace WebRequest::getLimitOffset with ::getLimitOffsetForUser

https://gerrit.wikimedia.org/r/573031

DannyS712 moved this task from Unsorted to Migrate / Replace on the Technical-Debt board.Feb 19 2020, 12:47 AM
gerritbot added a comment.Feb 19 2020, 12:47 AM

Change 573033 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Replace WebRequest::getLimitOffset with ::getLimitOffsetForUser

https://gerrit.wikimedia.org/r/573033

DannyS712 updated the task description. (Show Details)Feb 19 2020, 12:51 AM
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.21; 2020-02-25).Feb 19 2020, 1:00 AM
gerritbot added a comment.Feb 19 2020, 1:03 AM

Change 573030 merged by jenkins-bot:
[mediawiki/extensions/ProofreadPage@master] Replace WebRequest::getLimitOffset with ::getLimitOffsetForUser

https://gerrit.wikimedia.org/r/573030

gerritbot added a comment.Feb 19 2020, 1:36 AM

Change 573033 merged by jenkins-bot:
[mediawiki/core@master] Replace WebRequest::getLimitOffset with ::getLimitOffsetForUser

https://gerrit.wikimedia.org/r/573033

DannyS712 updated the task description. (Show Details)Feb 19 2020, 1:37 AM
gerritbot added a comment.Feb 19 2020, 2:31 AM

Change 573027 merged by jenkins-bot:
[mediawiki/extensions/CentralNotice@master] Replace WebRequest::getLimitOffset with ::getLimitOffsetForUser

https://gerrit.wikimedia.org/r/573027

DannyS712 updated the task description. (Show Details)Feb 19 2020, 5:40 AM
gerritbot added a comment.Feb 19 2020, 5:41 AM

Change 573068 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Deprecate WebRequest::getLimitOffset

https://gerrit.wikimedia.org/r/573068

DannyS712 updated the task description. (Show Details)Feb 19 2020, 5:44 AM
gerritbot added a comment.Feb 20 2020, 2:41 AM

Change 573031 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Replace WebRequest::getLimitOffset with ::getLimitOffsetForUser

https://gerrit.wikimedia.org/r/573031

gerritbot added a comment.Feb 20 2020, 2:41 AM

Change 573029 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] Replace WebRequest::getLimitOffset with ::getLimitOffsetForUser

https://gerrit.wikimedia.org/r/573029

DannyS712 updated the task description. (Show Details)Feb 20 2020, 2:42 AM
gerritbot added a comment.Feb 20 2020, 6:26 PM

Change 573068 merged by jenkins-bot:
[mediawiki/core@master] Hard deprecate WebRequest::getLimitOffset

https://gerrit.wikimedia.org/r/573068

Maintenance_bot removed a project: Patch-For-Review.Feb 20 2020, 7:10 PM
DannyS712 closed this task as Resolved.Feb 20 2020, 8:45 PM
DannyS712 updated the task description. (Show Details)
DannyS712 mentioned this in T245777: Remove WebRequest::getLimitOffset.
DannyS712 mentioned this in T243708: Mediawiki core needs uses of global $wgUser removed.Feb 22 2020, 1:18 AM
DannyS712 moved this task from Awaiting review and deployment to Resolved (deprecation) on the User-DannyS712 board.Feb 23 2020, 10:23 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL