Page MenuHomePhabricator
Create Task
Maniphest T243817

Browsertest for showing tainted icon after canceling edit
Closed, ResolvedPublic
Actions

Details

SubjectRepoBranchLines +/-
TR: Test taintedIcon show after cancel edit on tainted statementsmediawiki/extensions/Wikibasemaster+11 -4
Customize query in gerrit

Related Objects
Search...

Event Timeline

Tarrow created this task.Jan 28 2020, 10:56 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 28 2020, 10:56 AM
Rosalie_WMDE moved this task from To Do to Doing on the Wikidata-Tainted-References-Sprint9 board.Jan 28 2020, 3:56 PM
Tarrow assigned this task to Rosalie_WMDE.Jan 29 2020, 11:26 AM
Addshore moved this task from incoming to in progress on the Wikidata board.Jan 29 2020, 3:06 PM
gerritbot added a comment.Jan 30 2020, 12:59 PM

Change 568967 had a related patch set uploaded (by Rosalie Perside (WMDE); owner: Rosalie Perside (WMDE)):
[mediawiki/extensions/Wikibase@master] TR: Test taintedIcon show after cancel edit on tainted statements

https://gerrit.wikimedia.org/r/568967

gerritbot added a project: Patch-For-Review.Jan 30 2020, 12:59 PM
Rosalie_WMDE updated the task description. (Show Details)Jan 30 2020, 1:00 PM
Rosalie_WMDE updated the task description. (Show Details)

The Gerrit patch depends on this pull request: https://github.com/wmde/wdio-wikibase/pull/14

Rosalie_WMDE moved this task from Doing to Peer Review on the Wikidata-Tainted-References-Sprint9 board.Jan 30 2020, 1:01 PM
WMDE-leszek added a project: Wikidata-Tainted-References-Sprint10.Feb 3 2020, 9:38 AM
WMDE-leszek moved this task from To Do to Peer Review on the Wikidata-Tainted-References-Sprint10 board.Feb 3 2020, 10:00 AM
hoo subscribed.Feb 6 2020, 11:47 AM
In T243817#5840035, @Rosalie_WMDE wrote:

The Gerrit patch depends on this pull request: https://github.com/wmde/wdio-wikibase/pull/14

Merged and released as 2.3.0.

WMDE-leszek subscribed.EditedFeb 6 2020, 5:38 PM

Version number was not bumped in package.json file, hence publishing the new npm version didn't work, see: https://travis-ci.org/wmde/wdio-wikibase/jobs/646949890#L183

npm ERR! 403 403 Forbidden - PUT https://registry.npmjs.org/wdio-wikibase - You cannot publish over the previously published versions: 2.2.0.

I've submitted https://github.com/wmde/wdio-wikibase/pull/16 to fix the versions

Rosalie_WMDE moved this task from Peer Review to Doing on the Wikidata-Tainted-References-Sprint10 board.Feb 7 2020, 10:50 AM
Rosalie_WMDE moved this task from Doing to Peer Review on the Wikidata-Tainted-References-Sprint10 board.Feb 10 2020, 9:48 AM
Rosalie_WMDE renamed this task from Browsertest for showing tainted icon after cancelling edit to Browsertest for showing tainted icon after canceling edit.Feb 10 2020, 11:22 AM
Tarrow moved this task from Peer Review to Done on the Wikidata-Tainted-References-Sprint10 board.Feb 12 2020, 9:45 AM
gerritbot added a comment.Feb 12 2020, 10:04 AM

Change 568967 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] TR: Test taintedIcon show after cancel edit on tainted statements

https://gerrit.wikimedia.org/r/568967

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.20; 2020-02-18).Feb 12 2020, 11:00 AM
Rosalie_WMDE closed this task as Resolved.Feb 13 2020, 3:31 PM
Rosalie_WMDE removed a project: Patch-For-Review.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL