Page MenuHomePhabricator
Create Task
Maniphest T243819

Double encoding of "title" parameter
Open, Needs TriagePublicBUG REPORT
Actions

Description

On Special:RunQuery, a "title" hidden field is included in the form, containing the page title.

This field, contains URL-encoded value, which, when re-submitting the page, will get double encoded in the URL, causing a BadTitle redirect.

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/PageFormsmaster+4 -2Fix double escaping of "title" parameter
Customize query in gerrit

Event Timeline

ItSpiderman created this task.Jan 28 2020, 11:05 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 28 2020, 11:05 AM
ItSpiderman added a comment.Jan 28 2020, 11:13 AM

Submitted a patch with the proposed fix

gerritbot added a comment.Jan 28 2020, 7:05 PM

Change 567877 had a related patch set uploaded (by Ammarpad; owner: ItSpiderman):
[mediawiki/extensions/PageForms@master] Fix double escaping of "title" parameter

https://gerrit.wikimedia.org/r/567877

gerritbot added a project: Patch-For-Review.Jan 28 2020, 7:05 PM
gerritbot added a comment.Jan 29 2020, 1:15 PM

Change 567877 abandoned by ItSpiderman:
Fix double escaping of "title" parameter

Reason:
Already fixed

https://gerrit.wikimedia.org/r/567877

ItSpiderman added a comment.Jan 29 2020, 1:16 PM

This is only presetnt in version 4.6, not in any of the current branches

Maintenance_bot removed a project: Patch-For-Review.Jan 29 2020, 2:10 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL