Reference -Preview and -Popup shown both with Minerva in desktop mode
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

Steps to Reproduce:

Install and enable MobileFrontend, MinervaNeue and the Page-Previews extension with Reference Previews.
Visit a page with references using MinervaNeue in desktop mode

Actual Results:

When you hover a reference link in an article you will see the Reference Previews popup in the article
If you click the reference link now you will see the MobileFrontend at the bottom of the page

Expected Results:

I would assume it just make sense to have one of the two. Either the Reference Previews behavior with the popup in the text or the popup at the bottom of the page. I'm currently not entirely sure which one should be approached though.

Details

	Subject	Repo	Branch	Lines +/-
	Disable Reference Previews in the (mobile) Minerva skin	mediawiki/extensions/Popups	master	+7 -4

Customize query in gerrit

Related Objects

Mentioned In: T345833: ReferencePreviews: Final round of manual tests before full rollout
T281352: Broken settings dialogue for reference previews when in conflict with a skin/gadget
T258096: Regression: Nested references do not open if user clicks on [ or ] (which are wrapped in span)

Event Timeline

WMDE-Fisch created this task.Jan 28 2020, 11:38 AM

Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald TranscriptJan 28 2020, 11:38 AM

Aklapper renamed this task from Reference -Preview and -Popup shown both with Minearva in desktop mode to Reference -Preview and -Popup shown both with Minerva in desktop mode.Apr 29 2020, 3:01 PM

This is causing browser tests failures for Minerva as it seems to interferes with the behavior for the nested references. Can references preview please be disabled on Minerva skin for now until we have a plan?

Jdlrobson moved this task from Backlog to team:other on the MobileFrontend board.Jul 24 2020, 2:41 AM

Change 616060 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/Popups@master] Disable Reference Previews in the (mobile) Minerva skin

https://gerrit.wikimedia.org/r/616060

gerritbot added a project: Patch-For-Review.Jul 24 2020, 11:02 AM

Sure, we can disable Reference Previews on Minerva. (Just to be sure I just confirmed that the conflicting feature is indeed in Minerva, and not in MobileFrontend). I just uploaded a tiny patch that does this. But: Isn't the idea that "hover" actions don't work on mobile devices? Shouldn't we disable Page-Previews altogether?