Page MenuHomePhabricator

stashbot should only comment in phab once when the same task number is referenced twice
Closed, ResolvedPublic


Stashbot commented twice in a situation I would have only expected it to comment once for T219123#5836507 and T219123#5836508

Event Timeline

@Addshore I can't find those anchors on T219123: Migrate to and read from new store for item terms. Can you double check and help me understand what happened and what you expected to happen?

From the description here is sounds like someone wrote a message something like !log Did foo for T243843, T243843 and Stashbot didn't de-duplicate that to a single Phabricator update. Is that roughly correct @Addshore?

Change 588130 had a related patch set uploaded (by BryanDavis; owner: Bryan Davis):
[labs/tools/stashbot@master] De-duplicate task ids found in !log messages

bd808 moved this task from Backlog to Accepted on the Stashbot board.

Change 588130 merged by jenkins-bot:
[labs/tools/stashbot@master] De-duplicate task ids found in !log messages

Mentioned in SAL (#wikimedia-cloud) [2020-04-12T04:11:45Z] <bd808> Hopefully fixed T243843, T243843, T243843, and T243843 (deliberate duplication there folks)