Page MenuHomePhabricator

Remove hardcoded DataAccessSettings::USE_REPOSITORY_PREFIX_BASED_FEDERATION in various service constructions
Closed, ResolvedPublic

Description

In T243841 I discovered that https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Wikibase/+/566065/ broke the installation process.
This was due to a bit of code hardcoding DataAccessSettings::USE_REPOSITORY_PREFIX_BASED_FEDERATION in a service creation instead of using the right data access settings.
After an initial grep I also saw other code using this pattern, these should be found and fixed.

Details

Related Gerrit Patches:
mediawiki/extensions/WikibaseCirrusSearch : masterSearchEntitiesIntegrationTest use USE_ENTITY_SOURCE_BASED_FEDERATION
mediawiki/extensions/WikibaseMediaInfo : masterFix hardcoded USE_REPOSITORY_PREFIX_BASED_FEDERATION settings
mediawiki/extensions/Wikibase : masterFix hardcoded USE_REPOSITORY_PREFIX_BASED_FEDERATION settings

Related Objects

StatusSubtypeAssignedTask
Declineddchen
OpenNone
OpenNone
DuplicateNone
OpenNone
ResolvedAbit
OpenNone
DuplicateNone
OpenNone
OpenNone
OpenNone
ResolvedRamsey-WMF
ResolvedCparle
ResolvedJdforrester-WMF
ResolvedJdforrester-WMF
OpenNone
OpenNone
ResolvedWMDE-leszek
ResolvedAddshore
ResolvedAddshore

Event Timeline

Addshore created this task.Jan 28 2020, 3:35 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 28 2020, 3:35 PM
Addshore claimed this task.Jan 28 2020, 3:41 PM
Addshore triaged this task as High priority.
Restricted Application added a project: User-Addshore. · View Herald TranscriptJan 28 2020, 3:41 PM

Change 567976 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/Wikibase@master] Fix hardcoded USE_REPOSITORY_PREFIX_BASED_FEDERATION settings

https://gerrit.wikimedia.org/r/567976

Addshore moved this task from incoming to in progress on the Wikidata board.Jan 28 2020, 4:13 PM

Change 567981 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/WikibaseMediaInfo@master] Fix hardcoded USE_REPOSITORY_PREFIX_BASED_FEDERATION settings

https://gerrit.wikimedia.org/r/567981

Change 567982 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/WikibaseCirrusSearch@master] SearchEntitiesIntegrationTest use USE_ENTITY_SOURCE_BASED_FEDERATION

https://gerrit.wikimedia.org/r/567982

Change 567976 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Fix hardcoded USE_REPOSITORY_PREFIX_BASED_FEDERATION settings

https://gerrit.wikimedia.org/r/567976

Change 567981 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Fix hardcoded USE_REPOSITORY_PREFIX_BASED_FEDERATION settings

https://gerrit.wikimedia.org/r/567981

Change 567982 merged by jenkins-bot:
[mediawiki/extensions/WikibaseCirrusSearch@master] SearchEntitiesIntegrationTest use USE_ENTITY_SOURCE_BASED_FEDERATION

https://gerrit.wikimedia.org/r/567982

Addshore closed this task as Resolved.Feb 3 2020, 9:30 AM