Remove hardcoded DataAccessSettings::USE_REPOSITORY_PREFIX_BASED_FEDERATION in various service constructions
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Addshore
	Jan 28 2020, 3:35 PM

Description

In T243841 I discovered that https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Wikibase/+/566065/ broke the installation process.
This was due to a bit of code hardcoding DataAccessSettings::USE_REPOSITORY_PREFIX_BASED_FEDERATION in a service creation instead of using the right data access settings.
After an initial grep I also saw other code using this pattern, these should be found and fixed.

Details

Subject	Repo	Branch	Lines +/-
SearchEntitiesIntegrationTest use USE_ENTITY_SOURCE_BASED_FEDERATION	mediawiki/extensions/WikibaseCirrusSearch	master	+15 -5
Fix hardcoded USE_REPOSITORY_PREFIX_BASED_FEDERATION settings	mediawiki/extensions/WikibaseMediaInfo	master	+10 -22
Fix hardcoded USE_REPOSITORY_PREFIX_BASED_FEDERATION settings	mediawiki/extensions/Wikibase	master	+28 -34

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Declined		dchen	T118706 Conduct heuristic evaluation of image upload and insert flow in VisualEditor
Open		None	T115858 Design improvements for mw.ForeignStructuredUpload.BookletLayout
Open		None	T115865 Insert image in content immediately after it's uploaded, skipping the "General settings" step
Duplicate		None	T115864 Figure out if the description of the image can be used as the caption on-wiki
Open	Feature	None	T53032 When inserting an image, set its caption by default to be the Commons image description
Open	Feature	None	T39534 Wikimedia Commons should support searching by color
Duplicate		None	T39535 Wikimedia Commons should support filtering by color
Resolved		None	T19503 Provide metadata support on Wikimedia Commons
Resolved		None	T51662 VisualEditor: Use Multimedia/Wikidata's proposed rich structured meta-data in the image insertion dialog
Resolved		None	T68108 [Epic] Store media information for files on Wikimedia Commons as structured data
Resolved		• Ramsey-WMF	T199352 Deploy Structured Data on Commons with arbitrary Statements
Resolved		Cparle	T204264 "Depicts crawling": Add displaying/editing statements to File page
Resolved		Jdforrester-WMF	T218913 Enable Depicts in production
Resolved		Jdforrester-WMF	T214075 Enable federated access to entities and properties from Wikidata to Commons
Resolved		None	T212144 Allow access to MediaInfo from wikitext on Commons
Invalid		None	T211800 Resolve ambiguity of entity ID prefixes used on Commons.
Resolved		WMDE-leszek	T214557 Allow accessing Wikibase entities from multiple (Wikibase) databases
Resolved		Addshore	T243846 Remove hardcoded DataAccessSettings::USE_REPOSITORY_PREFIX_BASED_FEDERATION in various service constructions
Resolved		Addshore	T243841 LogicException UnusableEntitySource on fresh install of Wikibase from PropertyInfoTable.php(74): Wikibase\DataAccess\UnusableEntitySource->getDatabaseName()

Event Timeline

Addshore created this task.Jan 28 2020, 3:35 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 28 2020, 3:35 PM

Addshore claimed this task.Jan 28 2020, 3:41 PM

Addshore triaged this task as High priority.

Addshore moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.

Restricted Application added a project: User-Addshore. · View Herald TranscriptJan 28 2020, 3:41 PM

Change 567976 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/Wikibase@master] Fix hardcoded USE_REPOSITORY_PREFIX_BASED_FEDERATION settings

https://gerrit.wikimedia.org/r/567976

gerritbot added a project: Patch-For-Review.Jan 28 2020, 3:53 PM

Addshore added a subtask: T243841: LogicException UnusableEntitySource on fresh install of Wikibase from PropertyInfoTable.php(74): Wikibase\DataAccess\UnusableEntitySource->getDatabaseName().Jan 28 2020, 3:54 PM

Addshore added a parent task: T214557: Allow accessing Wikibase entities from multiple (Wikibase) databases.

Addshore moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.

Addshore moved this task from incoming to in progress on the Wikidata board.Jan 28 2020, 4:13 PM

Change 567981 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/WikibaseMediaInfo@master] Fix hardcoded USE_REPOSITORY_PREFIX_BASED_FEDERATION settings

https://gerrit.wikimedia.org/r/567981

Change 567982 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/WikibaseCirrusSearch@master] SearchEntitiesIntegrationTest use USE_ENTITY_SOURCE_BASED_FEDERATION

https://gerrit.wikimedia.org/r/567982

Change 567976 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Fix hardcoded USE_REPOSITORY_PREFIX_BASED_FEDERATION settings

https://gerrit.wikimedia.org/r/567976

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.18; 2020-02-04).Jan 28 2020, 5:00 PM

Change 567981 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Fix hardcoded USE_REPOSITORY_PREFIX_BASED_FEDERATION settings

https://gerrit.wikimedia.org/r/567981

Addshore moved this task from Peer Review to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jan 29 2020, 11:10 AM

Addshore moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jan 29 2020, 5:06 PM

Change 567982 merged by jenkins-bot:
[mediawiki/extensions/WikibaseCirrusSearch@master] SearchEntitiesIntegrationTest use USE_ENTITY_SOURCE_BASED_FEDERATION

https://gerrit.wikimedia.org/r/567982

Addshore mentioned this in rEWCS86bd28150c03: SearchEntitiesIntegrationTest use USE_ENTITY_SOURCE_BASED_FEDERATION.Jan 30 2020, 9:50 AM

Maintenance_bot removed a project: Patch-For-Review.Jan 30 2020, 10:10 AM

Jakob_WMDE moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jan 30 2020, 10:17 AM

WMDE-leszek closed subtask T243841: LogicException UnusableEntitySource on fresh install of Wikibase from PropertyInfoTable.php(74): Wikibase\DataAccess\UnusableEntitySource->getDatabaseName() as Resolved.Jan 30 2020, 3:28 PM

Addshore closed this task as Resolved.Feb 3 2020, 9:30 AM