Page MenuHomePhabricator

TestDeprecatedAttributes.test_lastrevid fails with AssertionError
Closed, ResolvedPublic

Description

======================================================================
5658
FAIL: test_lastrevid (tests.wikibase_tests.TestDeprecatedAttributes)
5659
Test deprecated lastrevid.
5660
----------------------------------------------------------------------
5661
Traceback (most recent call last):
5662
  File "c:\projects\pywikibot-g4xqx\tests\wikibase_tests.py", line 86, in test_lastrevid
5663
    self.assertDeprecation()
5664
  File "c:\projects\pywikibot-g4xqx\tests\aspects.py", line 1636, in assertDeprecation
5665
    self.assertDeprecationFile(self.expect_warning_filename)
5666
  File "c:\projects\pywikibot-g4xqx\tests\aspects.py", line 1680, in assertDeprecationFile
5667
    .format(filename, item))
5668
AssertionError: expected warning filename c:\projects\pywikibot-g4xqx\tests\wikibase_tests.py; warning item: {message : DeprecationWarning("The trailing arguments ('sysop') of pywikibot.site.APISite.__init__ are deprecated. The value(s) provided for 'sysop' have been dropped.",), category : 'DeprecationWarning', filename : 'c:\\projects\\pywikibot-g4xqx\\pywikibot\\__init__.py', lineno : 1266, line : None}
5669
5670
----------------------------------------------------------------------
5671

https://ci.appveyor.com/project/Ladsgroup/pywikibot-g4xqx/builds/30420453/job/c1owydelcr1agfdv

Details

Event Timeline

Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. · View Herald Transcript

Change 568504 had a related patch set uploaded (by Xqt; owner: Xqt):
[pywikibot/core@master] [bugfix] remove sysop assignment it Site interface

https://gerrit.wikimedia.org/r/568504

Travis and AppVeyor logs are currently full of this warning: The trailing arguments ('sysop') of pywikibot.site.APISite.__init__ are deprecated. The value(s) provided for 'sysop' have been dropped. and full of some other deprecation warnings as well. Perhaps we should focus to reduce usage of deprecated stuff in library?

Travis and AppVeyor logs are currently full of this warning: The trailing arguments ('sysop') of pywikibot.site.APISite.__init__ are deprecated. The value(s) provided for 'sysop' have been dropped. and full of some other deprecation warnings as well. Perhaps we should focus to reduce usage of deprecated stuff in library?

The proposed patch removes a lot of these warnings

Change 568504 merged by jenkins-bot:
[pywikibot/core@master] [bugfix] remove sysop assignment in Site interfaces

https://gerrit.wikimedia.org/r/568504

The proposed patch removes a lot of these warnings

Can we close this then? Seems this particular case is solved