Page MenuHomePhabricator

Grant +2 gerrit rights for @polishdeveloper
Closed, ResolvedPublic

Assigned To
Authored By
polishdeveloper
Jan 29 2020, 9:53 PM
Tokens
"Like" token, awarded by xSavitar."Like" token, awarded by kostajh."Like" token, awarded by greg."Like" token, awarded by sbassett."Like" token, awarded by WMDE-leszek."Like" token, awarded by Ammarpad."Like" token, awarded by matmarex."Like" token, awarded by nray."Like" token, awarded by Volker_E."Like" token, awarded by Jdforrester-WMF."Like" token, awarded by bd808."Love" token, awarded by Niedzielski."Like" token, awarded by Mholloway."Like" token, awarded by Tgr."Like" token, awarded by Bawolff.

Description

With the end of January I'll stop being a WMF employee, but I'd like to continue working with MediaWiki code base as a volunteer contributor and help
Readers team with their work. I'll loose access to @pmiazga account, but I still want to help with MediaWiki code, thus I created my volunteer phab/gerrit accounts @polishdeveloper.

Based on @pmiazga account, please grant the +2 permissions to MediaWiki extensions and MediaWiki core to polishdeveloper account.

//cc @phuedx @Jdlrobson @dr0ptp4kt @MarkTraceur

Event Timeline

There's nothing inherently wmf about the pmiazga ldap account, you could probably continue using that if you wanted to. (With a separate rights request)

I'm not sure, pmiazga account has many permissions and I if I remember right I was using the PMiazga (WMF) mediawiki account, it's just easier to grant only contributor permissions to the new account.

https://tools.wmflabs.org/ldap/user/pmiazga is your rights list. The wmf group will probably be removed from that account after you're offboarded regardless of if you continue to use the account. I imagine similar for other rights. And its definitely possible to relink a phab account to not be with the wmf SUL account ( https://phabricator.wikimedia.org/settings/user/pmiazga/page/external/ ). Anyways, i dont think it really matters either way, and with a new account you dont have to use wmf's boring first initial last name scheme.

Btw, the polishdeveloper gerrit account is not currently linked to the phab @polishdeveloper phab account. You should probably do that (i think you can do that from https://phabricator.wikimedia.org/settings/user/polishdeveloper/page/external/ ) .

Thank you for the intention to continue contributing. Just to be clear, I understand this is a request about the "mediawiki" group.

I see contributions mostly on skins and "mobile" extensions, but also in MediaWiki core and assorted repositories. https://gerrit.wikimedia.org/r/#/q/owner:pmiazga+project:%255Emediawiki/.%252B

Was this announced on wikitech-l?

It was now.

matmarex added a subscriber: matmarex.

This is a bit silly, but… Can you somehow demonstrate that you're the same person? :D Looks like you still have access to @pmiazga, so just comment here with that account or something.

This is a bit silly, but… Can you somehow demonstrate that you're the same person? :D Looks like you still have access to @pmiazga, so just comment here with that account or something.

+1, fine with granting to @pmiazga, but we should be sure it's really hem.

Using old phab account for the last time, just to confirm that it is me.

@MarcoAurelio - sorry, I missed your ping, but looks like @Tgr already sent an email to wkitech-l. Thank you Gergo.
@matmarex to confirm, yes, @polishdeveloper is my volunteer contributor account and I will not use this (pmiazga) account any more.

This has a lot of +1's; who can act on this request?

Perhaps i'm missing something, but it looks like permissions were re-arranged in gerrit so nobody (other than gerrit2 <noc@wikimedia.org>, which i think is something special purpose for replication) can do this. Maybe I'm just missing something obvious with how gerrit permissions work.

Perhaps i'm missing something, but it looks like permissions were re-arranged in gerrit so nobody (other than gerrit2 <noc@wikimedia.org>, which i think is something special purpose for replication) can do this. Maybe I'm just missing something obvious with how gerrit permissions work.

We've moved Gerrit administrators to be controlled by a LDAP group. All people listed at https://tools.wmflabs.org/ldap/group/gerritadmin are Gerrit admins, and are able to act at this request.

@tstarling This one is ready to go. Could you please action it? Thanks.

Thank you @MarcoAurelio. Just to verify, am I getting +2 rights for both MWCore and extensions/skins or do I have to submit another ticket and specify the list of skins/extensions I'm working on ?

Thank you @MarcoAurelio. Just to verify, am I getting +2 rights for both MWCore and extensions/skins or do I have to submit another ticket and specify the list of skins/extensions I'm working on ?

@polishdeveloper You're being added to the mediawiki group which will give you access to MediaWiki core, all mediawiki/extensions/* repos and all mediawiki/skins/* repos, and probably a few more accesses as well. If you want to get added as owner of specific extensions/skins I guess that can be arranged but I'll let Tim answer that. Being added on mediawiki would make those redundant. Hope that it helps. Regards.

tstarling claimed this task.

I added Polishdeveloper to the mediawiki group in Gerrit.