Page MenuHomePhabricator
Create Task
Maniphest T243969

An incomplete message shown when adding a sitelink to a page whose item uses the current page
Closed, ResolvedPublic
Actions

Assigned To
ItamarWMDE
Authored By
Amire80
Jan 30 2020, 7:27 PM
Tags
Referenced Files
F31679846: Screenshot_20200313_182856.png
Mar 13 2020, 5:31 PM
F31540443: Screenshot_20200130-102522_Firefox Nightly.jpg
Jan 30 2020, 7:27 PM
F31540440: 20200130_102024.jpg
Jan 30 2020, 7:27 PM
Subscribers
Addshore
Aklapper
Amire80
Lydia_Pintscher
Tarrow

Description

I tried to link between the English Wikipedia article Latvian orthography (Q67693351) to the Russian Wikipedia article Латышский алфавит (Q1193493). I used the "Add link" dialog on the client to do this.

I got this error:

20200130_102024.jpg (1×1 px, 287 KB)

Saying "Error: $1" is definitely not supposed to happen. When I tried to merge the item on wikidata.org, I got this:

Screenshot_20200130-102522_Firefox Nightly.jpg (1×1 px, 260 KB)

So, the actual error is probably "The two items cannot be merged because one of them links to the other using the properties". This is probably the text that should be shown on the client dialog instead of "$1".

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Fix capitalization on "items"mediawiki/extensions/Wikibasemaster+1 -1
Add i18n key for failed item mergemediawiki/extensions/Wikibasemaster+8 -2
Add failed modification keywikibase/javascript-apimaster+14 -1
Customize query in gerrit

Related Objects

Event Timeline

Amire80 created this task.Jan 30 2020, 7:27 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 30 2020, 7:27 PM
Lydia_Pintscher added a project: Wikidata-Campsite.Feb 8 2020, 8:04 PM
Lydia_Pintscher moved this task from Incoming to Unconnected Stories on the Wikidata-Campsite board.
ItamarWMDE claimed this task.Feb 13 2020, 11:02 AM
ItamarWMDE moved this task from Unconnected Stories to Wikidata-Campsite-Iteration-∞ (On Hold) on the Wikidata-Campsite board.
ItamarWMDE edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)); removed Wikidata-Campsite.
ItamarWMDE moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Maintenance_bot moved this task from incoming to in progress on the Wikidata board.Feb 13 2020, 11:15 AM
Lydia_Pintscher subscribed.Feb 16 2020, 10:35 AM

I wonder if there is a connection to T245245.

gerritbot added a comment.Feb 20 2020, 4:57 PM

Change 573628 had a related patch set uploaded (by Itamar Givon; owner: Itamar Givon):
[wikibase/javascript-api@master] Add failed modification key

https://gerrit.wikimedia.org/r/573628

gerritbot added a project: Patch-For-Review.Feb 20 2020, 4:57 PM
ItamarWMDE moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Feb 21 2020, 9:12 AM
ItamarWMDE moved this task from Peer Review to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
ItamarWMDE moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Feb 21 2020, 9:33 AM
ItamarWMDE moved this task from Peer Review to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Feb 21 2020, 9:43 AM
gerritbot added a comment.Feb 21 2020, 10:52 AM

Change 573629 had a related patch set uploaded (by Itamar Givon; owner: Itamar Givon):
[mediawiki/extensions/Wikibase@master] Add i18n key for failed item merge

https://gerrit.wikimedia.org/r/573629

ItamarWMDE added a comment.EditedFeb 21 2020, 11:54 AM

Please review and merge 573628 first, as it needs to be merged before CI tests are run on 573629.

ItamarWMDE moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Feb 21 2020, 11:55 AM
Silvan_WMDE mentioned this in T242769: Wikibase UI API calls should request a specific errorformat and uselang.Feb 24 2020, 12:07 PM
Tarrow subscribed.Feb 26 2020, 10:30 AM

https://gerrit.wikimedia.org/r/c/wikibase/javascript-api/+/573628 adds support for unknown errors that contain no more localisable information (e.g. the only thing we have is the error code). I quickly asked @Lydia_Pintscher about that in the daily and we think that's the best thing to show to our users.

gerritbot added a comment.Feb 26 2020, 3:00 PM

Change 573628 merged by jenkins-bot:
[wikibase/javascript-api@master] Add failed modification key

https://gerrit.wikimedia.org/r/573628

gerritbot added a comment.Feb 28 2020, 8:41 AM

Change 573629 had a related patch set uploaded (by Addshore; owner: Itamar Givon):
[mediawiki/extensions/Wikibase@master] Add i18n key for failed item merge

https://gerrit.wikimedia.org/r/573629

gerritbot added a comment.Feb 28 2020, 9:14 AM

Change 573629 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Add i18n key for failed item merge

https://gerrit.wikimedia.org/r/573629

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.22; 2020-03-03).Feb 28 2020, 10:00 AM
ItamarWMDE moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Feb 28 2020, 10:14 AM
ItamarWMDE moved this task from Test (Verification) to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Tarrow moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Feb 28 2020, 10:17 AM
Lydia_Pintscher added a comment.Mar 13 2020, 5:31 PM

This seems to be working now \o/

Screenshot_20200313_182856.png (484×548 px, 51 KB)

Just two minor things:

  • item -> Item (We capitalize when talking about the specific Wikibase data model concepts like Item, Property, Lexeme)
  • Wikidata is not hard-coded I assume? If it is then maybe replace with $reponame or "central data repository" like in the first message in the underlying dialog.
Lydia_Pintscher moved this task from Test (Verification) to To Do (prioritised from top to bottom) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Mar 20 2020, 9:57 AM

Moving back to todo for the two questions above.

Addshore subscribed.May 4 2020, 1:15 PM

@ItamarWMDE as your still assigned to this one would you mind having a quick look at the questions above? :)
If not lets get you unassigned so someone else can pick this up!

gerritbot added a comment.May 4 2020, 3:04 PM

Change 594208 had a related patch set uploaded (by Itamar Givon; owner: Itamar Givon):
[mediawiki/extensions/Wikibase@master] Fix capitalization on "items"

https://gerrit.wikimedia.org/r/594208

ItamarWMDE added a comment.May 4 2020, 3:09 PM

@Addshore done :)

Thanks for the ping :)

ItamarWMDE moved this task from To Do (prioritised from top to bottom) to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.May 4 2020, 3:09 PM
Addshore moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.May 4 2020, 3:13 PM
gerritbot added a comment.May 4 2020, 3:34 PM

Change 594208 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Fix capitalization on "items"

https://gerrit.wikimedia.org/r/594208

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.31; 2020-05-05); removed MW-1.35-notes (1.35.0-wmf.22; 2020-03-03).May 5 2020, 8:01 AM
Lydia_Pintscher closed this task as Resolved.May 26 2020, 9:36 AM
Lydia_Pintscher moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.

\o/

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits