Page MenuHomePhabricator
Create Task
Maniphest T244002

Add getterTypes file to safe getter calls
Closed, ResolvedPublic
Actions

Description

Similar to what we do with actions and mutations

Details

SubjectRepoBranchLines +/-
TR: Add getterTypes to use constants for getter namesmediawiki/extensions/Wikibasemaster+93 -64
Customize query in gerrit

Event Timeline

Tarrow created this task.Jan 31 2020, 11:00 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 31 2020, 11:00 AM
WMDE-leszek added a project: Wikidata-Tainted-References-Sprint10.Feb 3 2020, 9:37 AM
Rosalie_WMDE claimed this task.Feb 3 2020, 2:53 PM
Rosalie_WMDE moved this task from To Do to Doing on the Wikidata-Tainted-References-Sprint10 board.
gerritbot added a comment.Feb 5 2020, 11:03 AM

Change 570284 had a related patch set uploaded (by Rosalie Perside (WMDE); owner: Rosalie Perside (WMDE)):
[mediawiki/extensions/Wikibase@master] [WIP] Add getterTypes

https://gerrit.wikimedia.org/r/570284

gerritbot added a project: Patch-For-Review.Feb 5 2020, 11:03 AM
Rosalie_WMDE moved this task from Doing to Peer Review on the Wikidata-Tainted-References-Sprint10 board.Feb 5 2020, 12:29 PM
Rosalie_WMDE moved this task from Peer Review to Done on the Wikidata-Tainted-References-Sprint10 board.Feb 5 2020, 5:00 PM
gerritbot added a comment.Feb 5 2020, 5:08 PM

Change 570284 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] TR: Add getterTypes to use constants for getter names

https://gerrit.wikimedia.org/r/570284

Maintenance_bot removed a project: Patch-For-Review.Feb 5 2020, 5:10 PM
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.19; 2020-02-11).Feb 5 2020, 6:00 PM
hoo moved this task from Done to Test (Product Review) on the Wikidata-Tainted-References-Sprint10 board.Feb 5 2020, 7:47 PM
Rosalie_WMDE moved this task from Test (Product Review) to Done on the Wikidata-Tainted-References-Sprint10 board.Feb 6 2020, 9:17 AM
Lydia_Pintscher closed this task as Resolved.Feb 10 2020, 11:37 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL