Page MenuHomePhabricator
Create Task
Maniphest T244039

Api tests: Hard deprecate ApiTestCase::doLogin, remove calls in favor of passing a user where needed
Closed, ResolvedPublic
Actions

Assigned To
DannyS712
Authored By
DannyS712
Feb 1 2020, 12:58 AM
Tags
Referenced Files
None
Subscribers
Aklapper
Daimona
DannyS712
• Pchelolo

Description

ApiTestCase::doLogin was soft deprecated in 1.31, but is still used. When called, it writes to $wgUser
Calls to this function should be removed in favor of passing a used when needed.
The function can then be hard deprecated

Deployed code:
https://codesearch.wmflabs.org/deployed/?q=%5C%24this-%3EdoLogin%5C(&i=nope&files=&repos=

  • MassMessage
  • Newsletter
  • Thanks
  • Wikibase
  • BounceHandler
  • CodeReview
  • ORES
  • TimedMediaHandler
  • TitleBlacklist

Details

Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

DannyS712 created this task.Feb 1 2020, 12:58 AM
DannyS712 updated the task description. (Show Details)
DannyS712 moved this task from Unsorted to Next on the User-DannyS712 board.Feb 1 2020, 1:00 AM
gerritbot added a comment.Feb 1 2020, 1:05 AM

Change 569293 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/MassMessage@master] Remove calls to ApiTestCase::doLogin

https://gerrit.wikimedia.org/r/569293

gerritbot added a project: Patch-For-Review.Feb 1 2020, 1:05 AM
DannyS712 added a project: MassMessage.Feb 1 2020, 1:09 AM
DannyS712 moved this task from Next to In progress on the User-DannyS712 board.
gerritbot added a comment.Feb 1 2020, 1:11 AM

Change 568233 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Thanks@master] Remove use of global $wgUser

https://gerrit.wikimedia.org/r/568233

gerritbot added a comment.Feb 1 2020, 2:47 AM

Change 569297 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/CodeReview@master] Remove calls to ApiTestCase::doLogin

https://gerrit.wikimedia.org/r/569297

gerritbot added a comment.Feb 1 2020, 7:51 AM

Change 569297 merged by jenkins-bot:
[mediawiki/extensions/CodeReview@master] Remove calls to ApiTestCase::doLogin

https://gerrit.wikimedia.org/r/569297

gerritbot added a comment.Feb 1 2020, 11:51 AM

Change 568233 merged by jenkins-bot:
[mediawiki/extensions/Thanks@master] Remove use of global $wgUser

https://gerrit.wikimedia.org/r/568233

gerritbot added a comment.Feb 1 2020, 11:51 AM

Change 569293 merged by jenkins-bot:
[mediawiki/extensions/MassMessage@master] Remove calls to ApiTestCase::doLogin

https://gerrit.wikimedia.org/r/569293

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.18; 2020-02-04).Feb 1 2020, 12:00 PM
Maintenance_bot removed a project: Patch-For-Review.Feb 1 2020, 12:10 PM
Daimona added a subscriber: Daimona.Feb 1 2020, 1:20 PM
DannyS712 added projects: MediaWiki-extensions-Newsletter, Thanks, MediaWiki-extensions-WikibaseRepository, MediaWiki-extensions-BounceHandler, MediaWiki-extensions-CodeReview, ORES, TimedMediaHandler, TitleBlacklist.Feb 2 2020, 8:00 AM
DannyS712 updated the task description. (Show Details)
Restricted Application added projects: Growth-Team, Wikidata, Machine-Learning-Team. · View Herald TranscriptFeb 2 2020, 8:00 AM
DannyS712 moved this task from Backlog to Doing (In progress) on the MassMessage board.Feb 2 2020, 8:00 AM
gerritbot added a comment.Feb 2 2020, 4:45 PM

Change 569368 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/BounceHandler@master] Remove use of ApiTestCase::doLogin

https://gerrit.wikimedia.org/r/569368

gerritbot added a project: Patch-For-Review.Feb 2 2020, 4:45 PM
gerritbot added a comment.Feb 3 2020, 6:29 AM

Change 569392 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/TitleBlacklist@master] Remove use of ApiTestCase::doLogin

https://gerrit.wikimedia.org/r/569392

gerritbot added a comment.Feb 3 2020, 6:34 AM

Change 569393 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Newsletter@master] Remove use of ApiTestCase::doLogin

https://gerrit.wikimedia.org/r/569393

gerritbot added a comment.Feb 3 2020, 6:40 AM

Change 569394 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/TimedMediaHandler@master] Remove confusing $this->doLogin() call

https://gerrit.wikimedia.org/r/569394

gerritbot added a comment.Feb 3 2020, 12:30 PM

Change 569394 merged by jenkins-bot:
[mediawiki/extensions/TimedMediaHandler@master] Remove confusing $this->doLogin() call

https://gerrit.wikimedia.org/r/569394

gerritbot added a comment.Feb 3 2020, 12:30 PM

Change 569393 merged by jenkins-bot:
[mediawiki/extensions/Newsletter@master] Remove use of ApiTestCase::doLogin

https://gerrit.wikimedia.org/r/569393

gerritbot added a comment.Feb 3 2020, 12:30 PM

Change 569392 merged by jenkins-bot:
[mediawiki/extensions/TitleBlacklist@master] Remove use of ApiTestCase::doLogin

https://gerrit.wikimedia.org/r/569392

DannyS712 mentioned this in rETBLeac758d44ac4: Remove use of ApiTestCase::doLogin.Feb 3 2020, 12:39 PM
gerritbot added a comment.Feb 3 2020, 1:17 PM

Change 569368 merged by jenkins-bot:
[mediawiki/extensions/BounceHandler@master] Remove use of ApiTestCase::doLogin

https://gerrit.wikimedia.org/r/569368

Maintenance_bot removed a project: Patch-For-Review.Feb 3 2020, 2:10 PM
DannyS712 updated the task description. (Show Details)Feb 3 2020, 4:09 PM
gerritbot added a comment.Feb 3 2020, 4:24 PM

Change 569572 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Thanks@master] Remove use of ApiTestCase::doLogin

https://gerrit.wikimedia.org/r/569572

gerritbot added a project: Patch-For-Review.Feb 3 2020, 4:24 PM
gerritbot added a comment.Feb 6 2020, 7:11 AM

Change 570526 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/ORES@master] Remove use of ApiTestCase::doLogin

https://gerrit.wikimedia.org/r/570526

gerritbot added a comment.Feb 6 2020, 7:19 AM

Change 570537 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Wikibase@master] Remove use of ApiTestCase::doLogin

https://gerrit.wikimedia.org/r/570537

DannyS712 moved this task from In progress to Awaiting review and deployment on the User-DannyS712 board.Feb 6 2020, 7:25 AM
• Usmanino set the point value for this task to 9.Feb 6 2020, 7:58 AM
• Usmanino edited subscribers, added: dandavison7; removed: Daimona, Aklapper, DannyS712.
DannyS712 removed the point value for this task.Feb 6 2020, 8:04 AM
DannyS712 edited subscribers, added: Daimona, Aklapper, DannyS712; removed: dandavison7.
gerritbot added a comment.Feb 6 2020, 11:32 AM

Change 570537 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Remove use of ApiTestCase::doLogin

https://gerrit.wikimedia.org/r/570537

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.19; 2020-02-11); removed MW-1.35-notes (1.35.0-wmf.18; 2020-02-04).Feb 6 2020, 12:00 PM
DannyS712 updated the task description. (Show Details)Feb 6 2020, 5:27 PM
DannyS712 moved this task from Untriaged to 2020 | MW 1.35 on the Technical-Debt (Deprecation process) board.Feb 6 2020, 7:57 PM
DannyS712 updated the task description. (Show Details)Feb 11 2020, 8:31 PM
Halfak moved this task from Unorganized to Lift Wing on the Machine-Learning-Team board.Feb 12 2020, 9:39 PM
• Pchelolo added a subscriber: • Pchelolo.Feb 15 2020, 2:08 AM

All uses have been eliminated.

gerritbot added a comment.Feb 15 2020, 2:20 AM

Change 569572 merged by jenkins-bot:
[mediawiki/extensions/Thanks@master] Remove use of ApiTestCase::doLogin

https://gerrit.wikimedia.org/r/569572

gerritbot added a comment.Feb 15 2020, 2:20 AM

Change 570526 merged by jenkins-bot:
[mediawiki/extensions/ORES@master] Remove use of ApiTestCase::doLogin

https://gerrit.wikimedia.org/r/570526

gerritbot added a comment.Feb 15 2020, 2:28 AM

Change 572379 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Hard deprecate ApiTestCase::doLogin

https://gerrit.wikimedia.org/r/572379

DannyS712 updated the task description. (Show Details)Feb 15 2020, 2:32 AM
DannyS712 mentioned this in T245332: Remove remaining ApiTestCase::doLogin calls.Feb 15 2020, 2:45 AM
DannyS712 triaged this task as Medium priority.Feb 15 2020, 2:58 AM
ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.20; 2020-02-18); removed MW-1.35-notes (1.35.0-wmf.19; 2020-02-11).Feb 15 2020, 3:00 AM
gerritbot added a comment.Feb 18 2020, 7:28 PM

Change 572379 merged by jenkins-bot:
[mediawiki/core@master] Hard deprecate ApiTestCase::doLogin

https://gerrit.wikimedia.org/r/572379

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.21; 2020-02-25); removed MW-1.35-notes (1.35.0-wmf.20; 2020-02-18).Feb 18 2020, 8:00 PM
Maintenance_bot removed a project: Patch-For-Review.Feb 18 2020, 8:10 PM
DannyS712 renamed this task from Api tests: Hard deprecate $this->doLogin, remove calls in favor of passing a user where needed to Api tests: Hard deprecate ApiTestCase::doLogin, remove calls in favor of passing a user where needed.Feb 18 2020, 8:33 PM
DannyS712 closed this task as Resolved.
DannyS712 moved this task from Awaiting review and deployment to Resolved (deprecation) on the User-DannyS712 board.Feb 18 2020, 10:26 PM
DannyS712 mentioned this in T243708: Mediawiki core needs uses of global $wgUser removed.Feb 22 2020, 1:18 AM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL