Page MenuHomePhabricator

Consider changing the name of the "item requires statement" constraint type
Open, Needs TriagePublic

Description

According to the 2020 report on Property constraints (T244043):

It would be possible to change the name of this constraint type to "subject requires statement" or similar both to accommodate new Wikibase entity types other than Items [(e.g., Properties)] and to avoid confusion with the "value requires statement" constraint type.

Event Timeline

I’m not sure Phabricator is the right venue for this… I think the only thing editors see of this constraint is the label of the constraint item, so if the label of that is changed on Wikidata, that ought to be enough to effectively rename the constraint – the extension itself doesn’t have any constraint names. (The name of the ConstraintChecker class in the code is already different: ItemChecker. That, and a few other mismatching checker names, can be renamed independently, and that shouldn’t have any user-visible effect.)

Edit: There’s also the name of the config setting, but that also doesn’t match the current label (it’s WBQualityConstraintsItemRequiresClaimConstraintId rather than WBQualityConstraintsItemRequiresStatementConstraintId).

the extension itself doesn’t have any constraint names

I didn't know, that's a good thing then. :-)

Yes, this depends on the community, but I'm trying to open Phabricator tasks for all possible changes to track them. Those that depend on the community are tagged with Wikidata.org (but I see I forgot to include the tag on some of the ones you link, I'll get to it now).