Setup stories for all Minerva templates (components)
Closed, DeclinedPublic
Actions

Assigned To

None

Authored By

	Jdlrobson
	Feb 3 2020, 5:20 AM

Description

A storybook was setup for Minerva. This will hopefully encourage code and UI consolidation. This task encompasses making sure everything inside Minerva thast can be documented is documented.

Developer notes

JR set one up while working on the storybook for Vector (T242674) which covers only the last modified bar and footer.

Acceptance criteria

Logo template in Minerva is documented.
Menu template in Minerva is documented.
The Footer template story works and is fully documented.
CI is updated so a storybook is published to docs.wikimedia.org

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Storybook added to MinervaNeue	mediawiki/skins/MinervaNeue	master	+8 K -69

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		None	T266072 [GOAL] Build Minerva the way we build Vector (adoption of SkinMustache)
		Declined		None	T244106 Setup stories for all Minerva templates (components)

Event Timeline

Jdlrobson created this task.Feb 3 2020, 5:20 AM

Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald TranscriptFeb 3 2020, 5:20 AM

Change 566110 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] Storybook added to MinervaNeue

https://gerrit.wikimedia.org/r/566110

gerritbot added a project: Patch-For-Review.Feb 3 2020, 5:21 AM

Jdlrobson triaged this task as Medium priority.Feb 3 2020, 1:59 PM

MBinder_WMF renamed this task from Setup storybook from Minerva to [M] Setup storybook from Minerva.Feb 12 2020, 5:42 PM

temporarily moving back to triaged but future while we're gaining a bit more momentum on desktop improvements

ovasileva moved this task from Incoming to Triaged but Future on the Web-Team-Backlog-Archived board.Feb 13 2020, 11:32 AM

Change 566110 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Storybook added to MinervaNeue

https://gerrit.wikimedia.org/r/566110

Jdlrobson renamed this task from [M] Setup storybook from Minerva to [M] Setup storybook for all Minerva components.Mar 3 2020, 4:44 PM

Jdlrobson removed a project: Patch-For-Review.

Jdlrobson updated the task description. (Show Details)

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.24; 2020-03-17).Mar 3 2020, 5:00 PM

Jdforrester-WMF edited projects, added MW-1.35-notes (1.35.0-wmf.23; 2020-03-10); removed MW-1.35-notes (1.35.0-wmf.24; 2020-03-17).Mar 5 2020, 3:01 PM

Jdlrobson renamed this task from [M] Setup storybook for all Minerva components to Setup stories for all Minerva templates (components).Jun 11 2021, 9:22 PM

Jdlrobson edited projects, added good first task, patch-welcome; removed MW-1.35-notes (1.35.0-wmf.23; 2020-03-10).

Jdlrobson updated the task description. (Show Details)

@Jdforrester-WMF how do I make sure storybook is published on docs.wikimedia.org for Minerva? It's being run in the npm run doc command but not showing up on https://doc.wikimedia.org/

Side note: I can't find any documentation on mediawiki.org

Jdlrobson added a parent task: T266072: [GOAL] Build Minerva the way we build Vector (adoption of SkinMustache).Jun 11 2021, 9:25 PM

Jdlrobson moved this task from Backlog to Code organisation on the MinervaNeue board.Jul 21 2021, 7:25 PM

Not a priority and likely not a good use of time at this current stage. Perhaps reopen when Mustache's PHP code has been cleaned up relating to SkinMustache.

Setup stories for all Minerva templates (components)Closed, DeclinedPublicActions