Page MenuHomePhabricator
Create Task
Maniphest T244112

MassMessage needs uses of global $wgUser removed
Open, Stalled, MediumPublic
Actions

Description

See parent task

Details

SubjectRepoBranchLines +/-
MassMessageJob: remove a read of $wgUsermediawiki/extensions/MassMessagemaster+1 -1
Remove use of global $wgUsermediawiki/extensions/MassMessagemaster+2 -6
Silence phpcs warning regarding use of $wgUsermediawiki/extensions/MassMessagemaster+2 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

DannyS712 triaged this task as Medium priority.Feb 3 2020, 9:36 AM
DannyS712 created this task.
Restricted Application added a project: User-DannyS712. · View Herald TranscriptFeb 3 2020, 9:36 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot added a comment.Feb 3 2020, 9:36 AM

Change 569517 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/MassMessage@master] Remove use of global $wgUser

https://gerrit.wikimedia.org/r/569517

gerritbot added a project: Patch-For-Review.Feb 3 2020, 9:36 AM
DannyS712 moved this task from Unsorted to Awaiting review and deployment on the User-DannyS712 board.Feb 3 2020, 9:38 AM
DannyS712 mentioned this in T159299: Deprecate and remove $wgUser.
DannyS712 added a parent task: T245959: WMF deployed extensions need uses of global $wgUser removed [tracking].Feb 23 2020, 10:29 PM
DannyS712 removed a parent task: T159299: Deprecate and remove $wgUser.
gerritbot added a comment.Jun 6 2020, 3:11 AM

Change 602790 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/MassMessage@master] Silence phpcs warning regarding use of $wgUser

https://gerrit.wikimedia.org/r/602790

gerritbot added a comment.Jun 7 2020, 5:17 PM

Change 602790 merged by jenkins-bot:
[mediawiki/extensions/MassMessage@master] Silence phpcs warning regarding use of $wgUser

https://gerrit.wikimedia.org/r/602790

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.36; 2020-06-09).Jun 7 2020, 6:00 PM
Nikerabbit moved this task from Backlog to Maintenance on the MassMessage board.Jan 26 2022, 9:21 AM
Aklapper edited projects, added Patch-Needs-Improvement; removed Patch-For-Review.Feb 3 2022, 4:38 PM
Aklapper removed DannyS712 as the assignee of this task.Mar 13 2022, 7:48 PM

Removing task assignee due to inactivity, as this open task has been assigned for more than two years. See the email sent to the task assignee on February 06th 2022 (and T295729).

Please assign this task to yourself again if you still realistically [plan to] work on this task - it would be welcome.

If this task has been resolved in the meantime, or should not be worked on ("declined"), please update its task status via "Add Action… 🡒 Change Status".

Also see https://www.mediawiki.org/wiki/Bug_management/Assignee_cleanup for tips how to best manage your individual work in Phabricator.

DannyS712 changed the task status from Open to Stalled.Mar 14 2022, 1:19 AM
DannyS712 claimed this task.

Hasn't been done yet because it writes to $wgUser, will do in 1.39 as part of the removal of $wgUser from everywhere

gerritbot added a comment.Jun 4 2022, 12:12 AM

Change 802831 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/MassMessage@master] MassMessageJob: remove a read of $wgUser

https://gerrit.wikimedia.org/r/802831

gerritbot added a project: Patch-For-Review.Jun 4 2022, 12:12 AM
Restricted Application removed a project: Patch-Needs-Improvement. · View Herald TranscriptJun 4 2022, 12:12 AM
gerritbot added a comment.Jun 4 2022, 7:44 PM

Change 802831 merged by jenkins-bot:

[mediawiki/extensions/MassMessage@master] MassMessageJob: remove a read of $wgUser

https://gerrit.wikimedia.org/r/802831

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.15; 2022-06-06).Jun 4 2022, 8:00 PM
Pppery edited projects, added Patch-Needs-Improvement; removed Patch-For-Review.Apr 2 2023, 1:10 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits