New edit summaries are not displayed on client wikis
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	matej_suchanek
	Feb 3 2020, 12:29 PM

Description

Taken from Special:RecentChanges on cswiki:

The entry refers to this change. On Wikidata, the summary is transformed to Changed label, description and/or aliases in 54 languages but it doesn't work on client wikis.

Details

	Subject	Repo	Branch	Lines +/-
	Remove redundant edit summary messages	mediawiki/extensions/Wikibase	master	+0 -16
	Add missing wbeditentity summary messages for clients	mediawiki/extensions/Wikibase	master	+9 -0

Customize query in gerrit

Related Objects
Search...

View Standalone Graph

This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.

Status	Subtype	Assigned	Task
			· · ·
Open		None	T220696 [Story] Create better edit summaries for wbeditentity API endpoint
Resolved	BUG REPORT	Jakob_WMDE	T244129 New edit summaries are not displayed on client wikis
			· · ·

Event Timeline

matej_suchanek created this task.Feb 3 2020, 12:29 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 3 2020, 12:29 PM

Addshore added a project: Wikidata-Campsite.Feb 3 2020, 1:35 PM

Addshore moved this task from incoming to needs discussion or investigation on the Wikidata board.

Sounds like the message is not loaded on clients when it should be.
TODO check...

Jakob_WMDE claimed this task.Feb 4 2020, 9:56 AM

Jakob_WMDE moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.

The problem is that, while the messages like wikibase-item-summary-wbeditentity-update-languages are loaded on clients, it only looks them up with the wikibase-entity- prefix (see ClientHooks), and not with the wikibase-item or wikibase-property one. I'm not entirely sure whether we intentionally made a distinction between properties and items for these messages. The contents appear to be the same.

I'll create a patch adding wikibase-entity-summary-wbeditentity-update-languages and friends. We can later delete the wikibase-property-... and wikibase-item-... ones if it turns out they're not needed.

Change 570047 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/Wikibase@master] Add missing wbeditentity summary messages for clients

https://gerrit.wikimedia.org/r/570047

gerritbot added a project: Patch-For-Review.Feb 4 2020, 1:13 PM

Jakob_WMDE moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Feb 4 2020, 1:52 PM

Lea_Lacroix_WMDE subscribed.Feb 5 2020, 10:24 AM

Change 570047 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Add missing wbeditentity summary messages for clients

https://gerrit.wikimedia.org/r/570047

Rosalie_WMDE moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Feb 5 2020, 3:48 PM

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.19; 2020-02-11).Feb 5 2020, 4:00 PM

Maintenance_bot removed a project: Patch-For-Review.Feb 5 2020, 4:10 PM

This can be verified on beta wikipedia now https://de.wikipedia.beta.wmflabs.org/wiki/Spezial:Letzte_%C3%84nderungen?hidepageedits=1&hidenewpages=1&hidecategorization=1&hidelog=1&limit=50&days=7&urlversion=2

Change 570618 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/Wikibase@master] Remove redundant edit summary messages

https://gerrit.wikimedia.org/r/570618

gerritbot added a project: Patch-For-Review.Feb 6 2020, 12:04 PM

Change 570618 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Remove redundant edit summary messages

https://gerrit.wikimedia.org/r/570618

Maintenance_bot removed a project: Patch-For-Review.Feb 6 2020, 4:11 PM