Page MenuHomePhabricator

New edit summaries are not displayed on client wikis
Closed, ResolvedPublicBUG REPORT

Description

Taken from Special:RecentChanges on cswiki:


The entry refers to this change. On Wikidata, the summary is transformed to Changed label, description and/or aliases in 54 languages but it doesn't work on client wikis.

Details

Related Gerrit Patches:
mediawiki/extensions/Wikibase : masterRemove redundant edit summary messages
mediawiki/extensions/Wikibase : masterAdd missing wbeditentity summary messages for clients

Related Objects

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMon, Feb 3, 12:29 PM
Addshore triaged this task as High priority.Tue, Feb 4, 9:49 AM
Addshore added a subscriber: Addshore.

Sounds like the message is not loaded on clients when it should be.
TODO check...

The problem is that, while the messages like wikibase-item-summary-wbeditentity-update-languages are loaded on clients, it only looks them up with the wikibase-entity- prefix (see ClientHooks), and not with the wikibase-item or wikibase-property one. I'm not entirely sure whether we intentionally made a distinction between properties and items for these messages. The contents appear to be the same.

I'll create a patch adding wikibase-entity-summary-wbeditentity-update-languages and friends. We can later delete the wikibase-property-... and wikibase-item-... ones if it turns out they're not needed.

Change 570047 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/Wikibase@master] Add missing wbeditentity summary messages for clients

https://gerrit.wikimedia.org/r/570047

Change 570047 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Add missing wbeditentity summary messages for clients

https://gerrit.wikimedia.org/r/570047

Change 570618 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/Wikibase@master] Remove redundant edit summary messages

https://gerrit.wikimedia.org/r/570618

Change 570618 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Remove redundant edit summary messages

https://gerrit.wikimedia.org/r/570618