Unused and discouraged. Can be replaced with getQueryInfo(). Step-by-step instructions: T244138#5862888.
Description
Details
Subject | Repo | Branch | Lines +/- | |
---|---|---|---|---|
Hard deprecate QueryPage::getSQL() | mediawiki/core | master | +9 -2 |
Event Timeline
@Vaibhav0199: This is about the mediawiki/core repository (see the tags here). Please see https://www.mediawiki.org/wiki/Gerrit/Tutorial and https://www.mediawiki.org/wiki/How_to_become_a_MediaWiki_hacker - thanks! :)
getQueryInfo() is returning null in the code and getSQL() is returning string in the code. I am not able to understand how can be getQueryInfo() overrided?
@Poojayadav12 Hi I'm currently in 2nd year Btech from HBTU Kanpur.
How did you get the source code for this task. Can you help me out ?
There are many examples of overriding this method. The null is just a dummy value.
See @Aklapper's comment above:
This is about the mediawiki/core repository (see the tags here). Please see https://www.mediawiki.org/wiki/Gerrit/Tutorial and https://www.mediawiki.org/wiki/How_to_become_a_MediaWiki_hacker - thanks! :)
You will find both methods in includes/specialpage/QueryPage.php in mediawiki/core repository.
[offtopic] @Vaibhav0199: Please see https://www.mediawiki.org/wiki/How_to_become_a_MediaWiki_hacker#Feedback,_questions_and_support where to ask general questions unrelated to the topic of this task. Thanks!
@matej_suchanek So do you mean I should replace getSQL() by getQueryInfo() and where we called getQueryInfo() function I should simply write it as null?
Certainly no. First, mark getSQL as @deprecated and note it in RELEASE-NOTES-1.35. Then, where getSQL() is overriden, getQueryInfo() must be overriden instead. Also getSQL() shouldn't be called anywhere. This applies to all extensions but does not to file includes/specialpage/QueryPage.php. You can use code search to locate files to be updated. They will probably be in separate repositories, not in mediawiki/core.
Eventually, getSQL will be removed and QueryPage.php simplified.
im trying to clone a repository but it is giving this error.
C:\xampp\htdocs>git clone ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CheckUser
Cloning into 'CheckUser'...
ssh: connect to host gerrit.wikimedia.org port 29418: Network is unreachable
fatal: Could not read from remote repository.
Please make sure you have the correct access rights
and the repository exists.
Please read https://www.mediawiki.org/wiki/Gerrit/Tutorial.
If you haven't already, create an account in Gerrit.
Then make sure you have synced correct SSH keys.
Then use git clone "ssh://USERNAME@gerrit.wikimedia.org:29418/mediawiki/extensions/CheckUser" where USERNAME is your Gerrit username.
(Hint: if you have also cloned MediaWiki, clone extensions to extensions/ folder.)
@Kapilchhipa4: Hi, please also see https://www.mediawiki.org/wiki/How_to_become_a_MediaWiki_hacker#Feedback,_questions_and_support - thanks!
Change 668550 had a related patch set uploaded (by Zabe; owner: Zabe):
[mediawiki/core@master] Soft deprecate QueryPage::getSQL()
Change 668550 merged by jenkins-bot:
[mediawiki/core@master] Hard deprecate QueryPage::getSQL()
Obsolete behavior MAY be removed after it has been hard deprecated for three months in the development version (the master branch) as well as in one major release