Page MenuHomePhabricator
Create Task
Maniphest T244181

[print] Article title hidden with mobile print styles
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT
Actions

Description

The main article title is hidden when printing from the mobile Wikipedia. This is due to print-specific CSS which hides the entire .header element, which contains the title of the article.

Screen Shot 2020-02-03 at 16.20.25.png (1×2 px, 1 MB)

Developer notes

Instead of hiding .pre-content I suggest hiding .minervatab-container, .page-actions-menu, minervasubtitle
Explicit seems better here and I assume we want to show tag line if shown (wikidata description) as well as title.

Details

ProjectBranchLines +/-Subject
mediawiki/skins/MinervaNeuemaster+3 -1Fix Minerva print mode to correctly show top of document
Customize query in gerrit

Event Timeline

Jdrewniak created this task.Feb 3 2020, 9:25 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 3 2020, 9:25 PM
Jdlrobson renamed this task from Article title hidden with mobile print styles to [print] Article title hidden with mobile print styles.Feb 4 2020, 7:43 AM
Jdlrobson assigned this task to ovasileva.
Jdlrobson moved this task from Incoming to Needs Prioritization on the Readers-Web-Backlog board.
ovasileva triaged this task as Medium priority.Feb 4 2020, 8:37 AM
ovasileva edited projects, added Readers-Web-Backlog (Kanbanana-2019-20-Q3); removed Readers-Web-Backlog.
Jdlrobson moved this task from Needs Analysis to Upcoming on the Readers-Web-Backlog (Kanbanana-2019-20-Q3) board.Feb 4 2020, 12:57 PM
Jdlrobson updated the task description. (Show Details)
Restricted Application added a subscriber: Masumrezarock100. · View Herald TranscriptFeb 4 2020, 12:58 PM
ovasileva set the point value for this task to 2.Feb 5 2020, 6:27 PM
ovasileva moved this task from Upcoming to Ready for Development on the Readers-Web-Backlog (Kanbanana-2019-20-Q3) board.
Jdlrobson moved this task from Ready for Development to Blocked on Others on the Readers-Web-Backlog (Kanbanana-2019-20-Q3) board.Feb 17 2020, 10:03 PM
Jdlrobson moved this task from Blocked on Others to Doing on the Readers-Web-Backlog (Kanbanana-2019-20-Q3) board.
gerritbot added a comment.Feb 17 2020, 10:05 PM

Change 572749 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] Fix Minerva print mode to correctly show top of document

https://gerrit.wikimedia.org/r/572749

gerritbot added a project: Patch-For-Review.Feb 17 2020, 10:05 PM
Jdlrobson reassigned this task from ovasileva to alexhollender_WMF.EditedFeb 17 2020, 10:24 PM
Jdlrobson removed alexhollender_WMF as the assignee of this task.
Jdlrobson moved this task from Doing to Needs Design Review on the Readers-Web-Backlog (Kanbanana-2019-20-Q3) board.
Jdlrobson moved this task from Needs Design Review to Needs Code Review on the Readers-Web-Backlog (Kanbanana-2019-20-Q3) board.
Jdlrobson added a subscriber: ovasileva.
Jdlrobson added a subscriber: alexhollender_WMF.
Jdlrobson added a subscriber: Jdlrobson.

Patch needs review from someone other than me. @alexhollender will probably want to check the change before the train but I don't think that needs to block merging/review.

ovasileva lowered the priority of this task from Medium to Low.Feb 18 2020, 11:23 AM
Volker_E added a subscriber: Volker_E.Feb 18 2020, 5:54 PM
Before Jon's patchAfter
image.png (872×1 px, 887 KB)
image.png (884×1 px, 698 KB)

Don't think @alexhollender focus is needed here tbh.

gerritbot added a comment.Feb 18 2020, 6:06 PM

Change 572749 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Fix Minerva print mode to correctly show top of document

https://gerrit.wikimedia.org/r/572749

Maintenance_bot removed a project: Patch-For-Review.Feb 18 2020, 6:11 PM
Volker_E moved this task from Needs Code Review to Ready for Signoff on the Readers-Web-Backlog (Kanbanana-2019-20-Q3) board.Feb 18 2020, 6:50 PM
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.21; 2020-02-25).Feb 18 2020, 7:00 PM
ovasileva closed this task as Resolved.Feb 19 2020, 9:36 AM
ovasileva claimed this task.

Confirmed on the beta cluster. Resolving.

Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL