Page MenuHomePhabricator

[print] Article title hidden with mobile print styles
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT

Description

The main article title is hidden when printing from the mobile Wikipedia. This is due to print-specific CSS which hides the entire .header element, which contains the title of the article.

Screen Shot 2020-02-03 at 16.20.25.png (1×2 px, 1 MB)

Developer notes

Instead of hiding .pre-content I suggest hiding .minervatab-container, .page-actions-menu, minervasubtitle
Explicit seems better here and I assume we want to show tag line if shown (wikidata description) as well as title.

Event Timeline

Jdlrobson renamed this task from Article title hidden with mobile print styles to [print] Article title hidden with mobile print styles.Feb 4 2020, 7:43 AM
Jdlrobson assigned this task to ovasileva.
Jdlrobson moved this task from Incoming to Needs Prioritization on the Readers-Web-Backlog board.

Change 572749 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] Fix Minerva print mode to correctly show top of document

https://gerrit.wikimedia.org/r/572749

Jdlrobson removed alexhollender_WMF as the assignee of this task.
Jdlrobson added a subscriber: ovasileva.
Jdlrobson added a subscriber: alexhollender_WMF.
Jdlrobson added a subscriber: Jdlrobson.

Patch needs review from someone other than me. @alexhollender will probably want to check the change before the train but I don't think that needs to block merging/review.

ovasileva lowered the priority of this task from Medium to Low.Feb 18 2020, 11:23 AM
Before Jon's patchAfter
image.png (872×1 px, 887 KB)
image.png (884×1 px, 698 KB)

Don't think @alexhollender focus is needed here tbh.

Change 572749 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Fix Minerva print mode to correctly show top of document

https://gerrit.wikimedia.org/r/572749

ovasileva claimed this task.

Confirmed on the beta cluster. Resolving.