Page MenuHomePhabricator

Explore how to update Wikibase statement search index whitelist on Commons
Open, Needs TriagePublic

Description

We have this:
Although haswbstatement searches work for many properties on Commons, haswbstatement:P1259 returns 0 results, even though many images on Commons have that statement. Per conversations with Erik, this appears to be happening because of a whitelist in Wikibase (https://github.com/wikimedia/operations-mediawiki-config/blob/master/wmf-config/SearchSettingsForWikibase.php#L65-L68)

We want this:
Preferably all statements would be indexed for haswbstatement searches, but if that's not feasible due to performance/logistics, we should add the most common/important properties on Commons, and that should include P1259 (coordinates of the point of view) and P571 (inception)

Acceptance Criteria:

  • haswbstatement:P1259, haswbstatement:P571, and other important Commons properties (TBD) return accurate results on Commons

During development, please test the following:

  • Test this feature while logged in AND logged out
  • Test this feature on at least one mobile browser

Event Timeline

@Ramsey-WMF

FYI this isn't just a config change, we don't have code that formats time or globe-coordinate values for the search index.

Can you say more about the use-case for these searches? Is this just so users can find file without a value for P1259 (for example)? Or do we want users to be able to find files where the coordinates of the point of view are within a bounding box, or within X distance of another point?

For now, we just need the basics.

Is this just so users can find file without a value for P1259 (for example)?

Yes.

Or do we want users to be able to find files where the coordinates of the point of view are within a bounding box, or within X distance of another point?

That would be fantastic, but it is not the point of this particular ticket. We need haswbstatement:P1259 (and -haswbstatement:P159) to work at all first, so users can get accurate counts/results of which files have or are missing certain properties.

Aklapper added a subscriber: Cparle.

Removing task assignee due to inactivity, as this open task has been assigned for more than two years. See the email sent to the task assignee on February 06th 2022 (and T295729).

Please assign this task to yourself again if you still realistically [plan to] work on this task - it would be welcome.

If this task has been resolved in the meantime, or should not be worked on ("declined"), please update its task status via "Add Action… 🡒 Change Status".

Also see https://www.mediawiki.org/wiki/Bug_management/Assignee_cleanup for tips how to best manage your individual work in Phabricator.