Page MenuHomePhabricator

ApiStructureTest::testParameters validation failing for flagged revs review module
Closed, ResolvedPublic

Description

Likely caused by T242887: Make ApiStructureTest work with ParamValidator

https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php72-docker/44627/console

Failures
13:45:28 There were 6 failures:
13:45:28 
13:45:28 1) ApiStructureTest::testParameters with data set "Module review, plain, parameter flag_accuracy" ('review', array(null, array('string', true, true, array('api-help-param-token', 'csrf')), null, false, array(1, array('0', '1', '2', '3'), array('apihelp-review-param-flag', 'accuracy')), array(1, array('0', '1', '2', '3'), array('apihelp-review-param-flag', 'depth')), array(1, array('0', '1', '2', '3'), array('apihelp-review-param-flag', 'style'))), 'flag_accuracy')
13:45:28 === Logs generated by test case
13:45:28 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
13:45:28 ===
13:45:28 Module review, plain, parameter flag_accuracy: Validation failed: Value for PARAM_DEFAULT does not validate (code badvalue)
13:45:28 
13:45:28 /workspace/src/tests/phpunit/structure/ApiStructureTest.php:143
13:45:28 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:416
13:45:28 /workspace/src/maintenance/doMaintenance.php:99
13:45:28 
13:45:28 2) ApiStructureTest::testParameters with data set "Module review, plain, parameter flag_depth" ('review', array(null, array('string', true, true, array('api-help-param-token', 'csrf')), null, false, array(1, array('0', '1', '2', '3'), array('apihelp-review-param-flag', 'accuracy')), array(1, array('0', '1', '2', '3'), array('apihelp-review-param-flag', 'depth')), array(1, array('0', '1', '2', '3'), array('apihelp-review-param-flag', 'style'))), 'flag_depth')
13:45:28 === Logs generated by test case
13:45:28 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
13:45:28 ===
13:45:28 Module review, plain, parameter flag_depth: Validation failed: Value for PARAM_DEFAULT does not validate (code badvalue)
13:45:28 
13:45:28 /workspace/src/tests/phpunit/structure/ApiStructureTest.php:143
13:45:28 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:416
13:45:28 /workspace/src/maintenance/doMaintenance.php:99
13:45:28 
13:45:28 3) ApiStructureTest::testParameters with data set "Module review, plain, parameter flag_style" ('review', array(null, array('string', true, true, array('api-help-param-token', 'csrf')), null, false, array(1, array('0', '1', '2', '3'), array('apihelp-review-param-flag', 'accuracy')), array(1, array('0', '1', '2', '3'), array('apihelp-review-param-flag', 'depth')), array(1, array('0', '1', '2', '3'), array('apihelp-review-param-flag', 'style'))), 'flag_style')
13:45:28 === Logs generated by test case
13:45:28 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
13:45:28 ===
13:45:28 Module review, plain, parameter flag_style: Validation failed: Value for PARAM_DEFAULT does not validate (code badvalue)
13:45:28 
13:45:28 /workspace/src/tests/phpunit/structure/ApiStructureTest.php:143
13:45:28 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:416
13:45:28 /workspace/src/maintenance/doMaintenance.php:99
13:45:28 
13:45:28 4) ApiStructureTest::testParameters with data set "Module review, for help, parameter flag_accuracy" ('review', array(null, array('string', true, true, array('api-help-param-token', 'csrf')), null, false, array(1, array('0', '1', '2', '3'), array('apihelp-review-param-flag', 'accuracy')), array(1, array('0', '1', '2', '3'), array('apihelp-review-param-flag', 'depth')), array(1, array('0', '1', '2', '3'), array('apihelp-review-param-flag', 'style'))), 'flag_accuracy')
13:45:28 === Logs generated by test case
13:45:28 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
13:45:28 ===
13:45:28 Module review, for help, parameter flag_accuracy: Validation failed: Value for PARAM_DEFAULT does not validate (code badvalue)
13:45:28 
13:45:28 /workspace/src/tests/phpunit/structure/ApiStructureTest.php:143
13:45:28 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:416
13:45:28 /workspace/src/maintenance/doMaintenance.php:99
13:45:28 
13:45:28 5) ApiStructureTest::testParameters with data set "Module review, for help, parameter flag_depth" ('review', array(null, array('string', true, true, array('api-help-param-token', 'csrf')), null, false, array(1, array('0', '1', '2', '3'), array('apihelp-review-param-flag', 'accuracy')), array(1, array('0', '1', '2', '3'), array('apihelp-review-param-flag', 'depth')), array(1, array('0', '1', '2', '3'), array('apihelp-review-param-flag', 'style'))), 'flag_depth')
13:45:28 === Logs generated by test case
13:45:28 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
13:45:28 ===
13:45:28 Module review, for help, parameter flag_depth: Validation failed: Value for PARAM_DEFAULT does not validate (code badvalue)
13:45:28 
13:45:28 /workspace/src/tests/phpunit/structure/ApiStructureTest.php:143
13:45:28 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:416
13:45:28 /workspace/src/maintenance/doMaintenance.php:99
13:45:28 
13:45:28 6) ApiStructureTest::testParameters with data set "Module review, for help, parameter flag_style" ('review', array(null, array('string', true, true, array('api-help-param-token', 'csrf')), null, false, array(1, array('0', '1', '2', '3'), array('apihelp-review-param-flag', 'accuracy')), array(1, array('0', '1', '2', '3'), array('apihelp-review-param-flag', 'depth')), array(1, array('0', '1', '2', '3'), array('apihelp-review-param-flag', 'style'))), 'flag_style')
13:45:28 === Logs generated by test case
13:45:28 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
13:45:28 ===
13:45:28 Module review, for help, parameter flag_style: Validation failed: Value for PARAM_DEFAULT does not validate (code badvalue)
13:45:28 
13:45:28 /workspace/src/tests/phpunit/structure/ApiStructureTest.php:143
13:45:28 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:416
13:45:28 /workspace/src/maintenance/doMaintenance.php:99
13:45:28 
13:45:28 FAILURES!
13:45:28 Tests: 6143, Assertions: 15874, Failures: 6, Skipped: 70.