Page MenuHomePhabricator

FreezeWritesToCluster doesn't use API i18n functions
Closed, ResolvedPublic


	public function getParamDescription() {
		return [
			'thaw' => 'Allow writes to the elasticsearch cluster. When not provided writes will be frozen.',

This stopped working in MW 1.34 when the parent functions (and callers) were removed

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

In this case i think i18n was avoided because this api module is only included when running the integration testing suite, it should never be available on a real site. As such there would be no point in translating it. Will simply drop the function.

Change 570716 had a related patch set uploaded (by EBernhardson; owner: EBernhardson):
[mediawiki/extensions/CirrusSearch@master] Drop unreferenced getParamDescription method

EBernhardson triaged this task as Low priority.
EBernhardson moved this task from needs triage to Current work on the Discovery-Search board.

Change 570716 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Drop unreferenced getParamDescription method