FreezeWritesToCluster doesn't use API i18n functions
Closed, ResolvedPublic
Actions

Description

	public function getParamDescription() {
		return [
			'thaw' => 'Allow writes to the elasticsearch cluster. When not provided writes will be frozen.',
		];
	}

This stopped working in MW 1.34 when the parent functions (and callers) were removed

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/extensions/CirrusSearch	master	+2 -6	Drop unreferenced getParamDescription method

Customize query in gerrit

Event Timeline

Reedy created this task.Feb 5 2020, 12:04 AM

Restricted Application added projects: Discovery-Search, Platform Engineering. · View Herald TranscriptFeb 5 2020, 12:04 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Reedy moved this task from Unsorted to Non-core-API stuff on the MediaWiki-Action-API board.Feb 5 2020, 12:04 AM

Anomie removed a project: Platform Engineering.Feb 5 2020, 2:28 PM

In this case i think i18n was avoided because this api module is only included when running the integration testing suite, it should never be available on a real site. As such there would be no point in translating it. Will simply drop the function.

Change 570716 had a related patch set uploaded (by EBernhardson; owner: EBernhardson):
[mediawiki/extensions/CirrusSearch@master] Drop unreferenced getParamDescription method

https://gerrit.wikimedia.org/r/570716

gerritbot added a project: Patch-For-Review.Feb 6 2020, 8:41 PM

EBernhardson claimed this task.Feb 6 2020, 8:41 PM

EBernhardson triaged this task as Low priority.

EBernhardson moved this task from needs triage to Current work on the Discovery-Search board.

EBernhardson edited projects, added Discovery-Search (Current work); removed Discovery-Search.

Change 570716 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Drop unreferenced getParamDescription method

https://gerrit.wikimedia.org/r/570716

Maintenance_bot removed a project: Patch-For-Review.Feb 7 2020, 9:11 AM

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.19; 2020-02-11).Feb 7 2020, 10:00 AM

EBernhardson moved this task from Incoming to Needs Reporting on the Discovery-Search (Current work) board.Feb 10 2020, 7:17 PM

TJones closed this task as Resolved.Feb 12 2020, 4:35 PM

FreezeWritesToCluster doesn't use API i18n functionsClosed, ResolvedPublicActions

Description

Details

Event Timeline

FreezeWritesToCluster doesn't use API i18n functions
Closed, ResolvedPublic
Actions