Page MenuHomePhabricator

See if we can remove delete vs truncate hack
Closed, ResolvedPublic

Description

Part of civi upstreaming

Details

Related Gerrit Patches:
wikimedia/fundraising/crm/civicrm : masterRevert WMF delete vs truncate hacks

Event Timeline

Change 570193 had a related patch set uploaded (by Eileen; owner: Eileen):
[wikimedia/fundraising/crm/civicrm@master] Revert WMF delete vs truncate hacks

https://gerrit.wikimedia.org/r/570193

There are 3 places in the code where we have hacked CiviCRM core to do DELETE FROM
  rather than TRUNCATE.
  
  These go right back to civicrm 4.2 and last time I tested (some years ago) running
  
   TRUNCATE TABLE civicrm_acl_contact_cache
  
  Was terribly slow on our system, despite it being empty. I never determined a reason for it being
  slow as received wisdom is that truncate is faster. Quite a lot has happened with our server
  since I last tested including various versions changing and re-testing on staging and live just now
  the above truncate is instant.
  
  My theory is that changes to mysql in the interim have resolved our special quirk and we no
  longer need this. However, I have decided to only change one place in the code for now (submitted commit ) & the
  2 other places can follow soon after, assuming nothing seems like it is of concern

Change 570193 merged by jenkins-bot:
[wikimedia/fundraising/crm/civicrm@master] Revert WMF delete vs truncate hacks

https://gerrit.wikimedia.org/r/570193

Eileenmcnaughton closed this task as Resolved.Feb 19 2020, 12:53 AM
Eileenmcnaughton moved this task from Backlog to Done on the Fundraising Sprint Dampness board.