Avoid copy+pasted parts (for margins, spacing etc.).
Description
Description
Details
Details
Subject | Repo | Branch | Lines +/- | |
---|---|---|---|---|
bridge: use mixin for bailout errors | mediawiki/extensions/Wikibase | master | +30 -38 |
Status | Subtype | Assigned | Task | ||
---|---|---|---|---|---|
Open | None | T228066 Step 1: Error States of Data-Bridge [Tracking] (impact: medium) | |||
Resolved | Charlie_WMDE | T238660 Step 1: bail-out path for deprecated main snaks (impact: medium) | |||
Resolved | Lucas_Werkmeister_WMDE | T244342 Reduce duplication in bail-out errors |
Event Timeline
Comment Actions
I have an idea for how to do this, and it seems to work, but I need to wait until the other spacing fixes are merged (currently in gate-and-submit) before I can upload it.
Comment Actions
Change 570328 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] bridge: use mixin for bailout errors
Comment Actions
Change 570328 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: use mixin for bailout errors
Comment Actions
@Michael @Tonina_Zhelyazkova_WMDE do we want to reduce any more duplication (e. g. in the <template> and <script> parts) or is this enough?
Comment Actions
No, I think the styles are enough. If we reduce some template code it might get confusing.