Page MenuHomePhabricator

Reduce duplication in bail-out errors
Closed, ResolvedPublic

Description

Avoid copy+pasted parts (for margins, spacing etc.).

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 5 2020, 10:36 AM
Lucas_Werkmeister_WMDE moved this task from To do to Doing on the Wikidata-Bridge-Sprint-13 board.

I have an idea for how to do this, and it seems to work, but I need to wait until the other spacing fixes are merged (currently in gate-and-submit) before I can upload it.

Change 570328 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] bridge: use mixin for bailout errors

https://gerrit.wikimedia.org/r/570328

Change 570328 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: use mixin for bailout errors

https://gerrit.wikimedia.org/r/570328

@Michael @Tonina_Zhelyazkova_WMDE do we want to reduce any more duplication (e. g. in the <template> and <script> parts) or is this enough?

@Michael @Tonina_Zhelyazkova_WMDE do we want to reduce any more duplication (e. g. in the <template> and <script> parts) or is this enough?

No, I think the styles are enough. If we reduce some template code it might get confusing.

Lucas_Werkmeister_WMDE closed this task as Resolved.Feb 6 2020, 10:55 AM

sounds good to me 👍