Page MenuHomePhabricator

Homer: commit> no causes stacktrace
Closed, ResolvedPublic

Description

Doesn't break the tool as it continues as expected but it shouldn't show the bellow error:

Type "yes" to commit, "no" to abort.
> no
ERROR:homer:Failed to commit on cr3-knams.wikimedia.org
Traceback (most recent call last):
  File "/home/xionox/Documents/Projects/Wikimedia-repos/homer/env/lib/python3.7/site-packages/homer-0.1.2.dev2+g9bd9c7f-py3.7.egg/homer/transports/junos.py", line 76, in commit
    callback(self._fqdn, diff)
  File "/home/xionox/Documents/Projects/Wikimedia-repos/homer/env/lib/python3.7/site-packages/homer-0.1.2.dev2+g9bd9c7f-py3.7.egg/homer/__init__.py", line 189, in callback
    raise HomerError('Commit aborted')
homer.exceptions.HomerError: Commit aborted

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/home/xionox/Documents/Projects/Wikimedia-repos/homer/env/lib/python3.7/site-packages/homer-0.1.2.dev2+g9bd9c7f-py3.7.egg/homer/__init__.py", line 198, in _device_commit
    connection.commit(device_config, message, callback, self._ignore_warning)
  File "/home/xionox/Documents/Projects/Wikimedia-repos/homer/env/lib/python3.7/site-packages/homer-0.1.2.dev2+g9bd9c7f-py3.7.egg/homer/transports/junos.py", line 79, in commit
    raise HomerError('Failed to prepare commit on {fqdn}'.format(fqdn=self._fqdn)) from e
homer.exceptions.HomerError: Failed to prepare commit on cr3-knams.wikimedia.org

Details

Related Changes in Gerrit:

Event Timeline

ayounsi triaged this task as Low priority.
Volans moved this task from Backlog to In Progress on the SRE-tools board.

Change 570483 had a related patch set uploaded (by Volans; owner: Volans):
[operations/software/homer@master] Handle commit abort separately

https://gerrit.wikimedia.org/r/570483

Change 570483 merged by jenkins-bot:
[operations/software/homer@master] Handle commit abort separately

https://gerrit.wikimedia.org/r/570483

Fix merged into master, will be part of the next release.