Setup.php on line 186
Closed, ResolvedPublic
Actions

Description

There is an error in Beta that is preventing beta-scap-eqiad from running:

RuntimeError: Scap failed!: Call to mwscript eval.php stderr: Notice: Undefined index: 1x in /srv/mediawiki-staging/php-master/includes/Setup.php on line 186

I noticed a couple of changes this morning that look possibly related:

d450288 wgLogoHD and $wgVectorPrintLogo is replaced with wgLogos (2/2) by jdlrobson · 3 hours ago master
5cc2b70 wgLogoHD and $wgVectorPrintLogo is replaced with wgLogos (1/2) by jdlrobson · 13 hours ago

https://gerrit.wikimedia.org/g/operations/mediawiki-config/+/d4502884%5E%21/
https://gerrit.wikimedia.org/g/operations/mediawiki-config/+/5cc2b70%5E%21/

Not clear how that could cause this offhand, but it does seem related.

Adding @Jdlrobson for input.

Details

Project	Branch	Lines +/-	Subject
translatewiki	master	+4 -4	Replace usage of $wgLogoHD with $wgLogos
mediawiki/core	master	+1 -1	Follow-up 8cd2e13: Setup: Check that 1x key has been set in wgLogos before using
operations/mediawiki-config	master	+3 -0	Set $wgLogos['1x'] (new style access) to $wgLogo (old style access)

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved	Goal	ovasileva	T242131 [GOAL] Deploy new header to at least one test wiki
Resolved		Jdlrobson	T240856 [EPIC] New header for desktop improvements project
Resolved		ovasileva	T232140 Separate out logo handling into square image logos and long text/wordmark banner logos
Resolved		Jdforrester-WMF	T244370 Beta: Undefined index: 1x in /srv/mediawiki-staging/php-master/includes/Setup.php on line 186

Event Timeline

thcipriani created this task.Feb 5 2020, 3:36 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 5 2020, 3:36 PM

Michael added a subscriber: Michael.Feb 5 2020, 3:37 PM

Lucas_Werkmeister_WMDE added a subscriber: Lucas_Werkmeister_WMDE.Feb 5 2020, 3:37 PM

This'll have been caused by 8cd2e13. Will dig.

Change 570365 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] Follow-up 8cd2e13: Setup: Check that 1x key has been set in wgLogos before using

https://gerrit.wikimedia.org/r/570365

gerritbot added a project: Patch-For-Review.Feb 5 2020, 3:44 PM

Change 570378 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[operations/mediawiki-config@master] Set $wgLogos['1x'] (new style access) to $wgLogo (old style access)

https://gerrit.wikimedia.org/r/570378

Change 570365 merged by jenkins-bot:
[mediawiki/core@master] Follow-up 8cd2e13: Setup: Check that 1x key has been set in wgLogos before using

https://gerrit.wikimedia.org/r/570365

Jdforrester-WMF claimed this task.Feb 5 2020, 6:24 PM

Jdforrester-WMF triaged this task as Unbreak Now! priority.

Jdforrester-WMF added a project: Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)).

Restricted Application added a subscriber: Liuxinyu970226. · View Herald TranscriptFeb 5 2020, 6:24 PM

Jdforrester-WMF moved this task from INBOX to Maintenance on the Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)) board.Feb 5 2020, 6:25 PM

I pointed this out in code review. Immediate bug fixed, so closing. Will follow up on parent task. I don't think the core compat code now works as intended for existing wikis, nor does it work for new wikis. It only works with the ad-hoc config state we now have in wmf-config, which also looks unintended...

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.19; 2020-02-11).Feb 5 2020, 7:00 PM

Reedy mentioned this in T244300: Argument 1 passed to Title::getLanguageConverter() must be an instance of Language, instance of StubUserLang given, called in /srv/mediawiki/php-1.35.0-wmf.18/includes/Title.php on line 207.Feb 5 2020, 7:01 PM

Change 570378 merged by jenkins-bot:
[operations/mediawiki-config@master] Set $wgLogos['1x'] (new style access) to $wgLogo (old style access)

https://gerrit.wikimedia.org/r/570378

Maintenance_bot removed a project: Patch-For-Review.Feb 5 2020, 7:10 PM

We were also affected by this during our translatewiki.net update.

Change 570375 had a related patch set uploaded (by Abijeet Patro; owner: Abijeet Patro):
[translatewiki@master] Replace usage of $wgLogoHD with $wgLogos

https://gerrit.wikimedia.org/r/570375

gerritbot added a project: Patch-For-Review.Feb 7 2020, 3:59 PM

Change 570375 merged by jenkins-bot:
[translatewiki@master] Replace usage of $wgLogoHD with $wgLogos

https://gerrit.wikimedia.org/r/570375

jenkins-bot mentioned this in rGTWNb33bcd5ab327: Replace usage of $wgLogoHD with $wgLogos.Feb 10 2020, 8:35 AM

Maintenance_bot removed a project: Patch-For-Review.Feb 10 2020, 9:10 AM